make starting balance never null

Author: zefir-git

src/main/java/pro/cloudnode/smp/bankaccounts/BankConfig.java

@@ -129,10 +129,10 @@ public boolean integrationsVaultEnabled() {
     }
 
     // starting-balance
-    public @NotNull Optional<@NotNull Double> startingBalance() {
+    public @NotNull BigDecimal startingBalance() {
         if (Objects.requireNonNull(config.getString("starting-balance")).equalsIgnoreCase("null"))
-            return Optional.empty();
-        else return Optional.of(config.getDouble("starting-balance"));
+            return BigDecimal.ZERO;
+        else return new BigDecimal(Objects.requireNonNull(config.getString("starting-balance")));
     }
 
     // server-account.name

src/main/java/pro/cloudnode/smp/bankaccounts/events/Join.java

@@ -10,22 +10,19 @@
 import pro.cloudnode.smp.bankaccounts.Permissions;
 
 import java.math.BigDecimal;
-import java.util.Optional;
 
 public final class Join implements Listener {
     @EventHandler
     public void onPlayerJoin(final @NotNull PlayerJoinEvent event) {
-        final Player player = event.getPlayer();
-        final @NotNull Optional<@NotNull Double> startingBalance = BankAccounts.getInstance().config()
-                .startingBalance();
-        startingBalance.ifPresent(aDouble -> BankAccounts.getInstance().getServer().getScheduler()
-                .runTaskAsynchronously(BankAccounts.getInstance(), () -> {
-                    if (Account.getVaultAccount(player).isEmpty()) {
-                        // if the player already has a personal account, they will not be given starting balance
-                        final @NotNull BigDecimal balance = Account.get(player, Account.Type.PERSONAL).length > 0 ? BigDecimal.ZERO : BigDecimal.valueOf(aDouble);
-                        new Account(player, Account.Type.VAULT, null, balance, false).insert();
-                    }
-                }));
+        final @NotNull Player player = event.getPlayer();
+        final @NotNull BigDecimal startingBalance = BankAccounts.getInstance().config().startingBalance();
+        BankAccounts.getInstance().getServer().getScheduler().runTaskAsynchronously(BankAccounts.getInstance(), () -> {
+            if (Account.getVaultAccount(player).isEmpty()) {
+                // if the player already has a personal account, they will not be given starting balance
+                final @NotNull BigDecimal balance = startingBalance.compareTo(BigDecimal.ZERO) <= 0 || Account.get(player, Account.Type.PERSONAL).length > 0 ? BigDecimal.ZERO : startingBalance;
+                new Account(player, Account.Type.VAULT, null, balance, false).insert();
+            }
+        });
         if (player.hasPermission(Permissions.NOTIFY_UPDATE)) {
             BankAccounts.getInstance().getServer().getScheduler().runTaskLaterAsynchronously(BankAccounts.getInstance(), () -> BankAccounts.checkForUpdates().ifPresent(latestVersion -> {
                 player.sendMessage(BankAccounts.getInstance().config().messagesUpdateAvailable(latestVersion));