remove reliance on LuckPerms group and run configurable commands

Author: zefir-git

src/main/java/pro/cloudnode/smp/smpcore/Configuration.java

@@ -4,7 +4,10 @@
 import net.kyori.adventure.text.minimessage.MiniMessage;
 import net.kyori.adventure.text.minimessage.tag.resolver.Formatter;
 import net.kyori.adventure.text.minimessage.tag.resolver.Placeholder;
+import org.bukkit.Bukkit;
+import org.bukkit.OfflinePlayer;
 import org.jetbrains.annotations.NotNull;
+import org.jetbrains.annotations.Nullable;
 
 import java.time.Duration;
 import java.time.temporal.ChronoUnit;
@@ -110,7 +113,17 @@ public boolean deathBanEnabled() {
         return MiniMessage.miniMessage().deserialize(Objects.requireNonNull(config.getString("staff.team.name")));
     }
 
-    public @NotNull String staffGroup() {
-        return Objects.requireNonNull(config.getString("staff.group"));
+    public void staffCommands(final boolean addMode, final @NotNull OfflinePlayer player) {
+        final @Nullable String name = player.getName();
+        if (name == null)
+            return;
+
+        final List<String> commands = config.getStringList("staff.commands." + (addMode ? "add" : "remove"));
+
+        for (final String command : commands)
+            Bukkit.dispatchCommand(
+                    Bukkit.getConsoleSender(),
+                    command.replace("<player>", name)
+            );
     }
 }

src/main/java/pro/cloudnode/smp/smpcore/command/MainCommand.java

@@ -5,7 +5,6 @@
 import net.kyori.adventure.text.TextComponent;
 import net.kyori.adventure.text.minimessage.MiniMessage;
 import net.kyori.adventure.text.minimessage.tag.resolver.Placeholder;
-import org.bukkit.Bukkit;
 import org.bukkit.OfflinePlayer;
 import org.bukkit.command.CommandSender;
 import org.bukkit.command.ConsoleCommandSender;
@@ -391,19 +390,15 @@ public static boolean member(
                     member.get().nation().ifPresent(nation -> nation.getTeam().removePlayer(member.get().player()));
 
                     Member.getStaffTeam().addPlayer(member.get().player());
-
-                    console.getServer().dispatchCommand(console, "luckperms:luckperms user "
-                            + member.get().player().getName() + " parent add " + SMPCore.config().staffGroup());
                 }
                 else {
                     Member.getStaffTeam().removePlayer(member.get().player());
 
                     member.get().nation().ifPresent(nation -> nation.getTeam().addPlayer(member.get().player()));
-
-                    console.getServer().dispatchCommand(console, "luckperms:luckperms user "
-                            + member.get().player().getName() + " parent remove " + SMPCore.config().staffGroup());
                 }
 
+                SMPCore.config().staffCommands(member.get().staff, member.get().player());
+
                 return sendMessage(sender, SMPCore.messages().membersSetStaff(member.get()));
             }
         }
@@ -471,10 +466,7 @@ private static boolean removeMember(final @NotNull Audience audience, final @Not
         if (target.staff) {
             Member.getStaffTeam().removePlayer(player);
 
-            final ConsoleCommandSender console = Bukkit.getConsoleSender();
-
-            Bukkit.dispatchCommand(console, "luckperms:luckperms user " + player.getName()
-                    + " parent remove " + SMPCore.config().staffGroup());
+            SMPCore.config().staffCommands(false, player);
         }
 
         if (!target.delete())

src/main/resources/config.yml

@@ -52,4 +52,8 @@ staff:
   team:
     id: staff
     name: <hover:show_text:'The shield that guards the realms of men.'><dark_red><b>STAFF</b></dark_red></hover>
-  group: staff
+  commands:
+    add:
+      - luckperms:luckperms user <player> parent remove staff
+    remove:
+      - luckperms:luckperms user <player> parent add staff

src/main/resources/plugin.yml

@@ -3,8 +3,6 @@ author: Cloudnode
 version: '${project.version}'
 main: pro.cloudnode.smp.smpcore.SMPCore
 api-version: '1.20'
-depend:
-  - LuckPerms
 commands:
   smpcore:
     description: SMPCore Main command