Merge branch 'release/v2.0.0'

Author: ppxl

CHANGELOG.md

@@ -4,7 +4,14 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
-## [v1.2.0](https://github.com/cloudogu/zalenium-build-lib/releases/tag/v1.1.0) - 2020-02-21
+## [v2.0.0](https://github.com/cloudogu/zalenium-build-lib/releases/tag/v2.0.0) - 2020-02-21
+
+Heads-up: Breaking change ahead!
+
+This version changes a hardcoded repository name into a changeable repository name in the `withMavenSettings.mvnWithSettings()` part. It does default to `maven-central` though. But if the need arises to choose a different repository, the new signature looks like this:
+```
+withMavenSettings.mvnWithSettings nexusCredentials, cesFQDN, yourDifferentRepositoryName, mvnCallArgs
+```
 
 ### Added
 - new lib function for running E2E tests with pure `Selenium` without the help of `Zalenium`
@@ -18,6 +25,14 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
    - Please note that the method `generateZaleniumJobName()` may be removed in future releases
 - `generateJobName` now uses `-` instead of `_` because of possible problems when used as DNS name 
 
+### Bugfix
+
+The release v1.2.0 introduced a defect in which the default Nexus mirror repository name was not properly set. This releases removes this defect (#9)
+
+## [v1.2.0](https://github.com/cloudogu/zalenium-build-lib/releases/tag/v1.1.0) - 2020-02-21
+
+This release contains breaking changes and should not be used. Instead use the release v2.0.0
+
 ## [v1.1.0](https://github.com/cloudogu/zalenium-build-lib/releases/tag/v1.1.0) - 2019-09-18 
 
 ### Added

vars/withMavenSettings.groovy

@@ -1,5 +1,3 @@
-final String defaultMavenCentralRepoName = "maven-central"
-
 /**
  * Provides a simple custom maven settings.xml file to current working directory with Maven Central mirror in the
  * current CES instance.
@@ -22,7 +20,7 @@ final String defaultMavenCentralRepoName = "maven-central"
  * @param mirrorNexusPath relative path to a maven central mirror hosted inside a nexus instance. The prefix <code>/nexus/repository</code> will be added automatically. Defaults to "maven-central"
  * @param closure This closure will be executed when the Maven <code>settings.xml</code> file was successfully created.
  */
-def settings(def nexusCredentials, String cesFQDN, String pathToLocalMavenRepository, String mirrorNexusPath=defaultMavenCentralRepoName, Closure closure) {
+def settings(def nexusCredentials, String cesFQDN, String pathToLocalMavenRepository, String mirrorNexusPath="maven-central", Closure closure) {
     echo "write settings.xml to ${pathToLocalMavenRepository}"
     echo "local Maven repository should be located at ${pathToLocalMavenRepository}/.m2/repository"
 
@@ -64,7 +62,7 @@ def settings(def nexusCredentials, String cesFQDN, String pathToLocalMavenReposi
  * @param mirrorNexusPath relative path to a maven central mirror hosted inside a nexus instance. The prefix <code>/nexus/repository</code> will be added automatically. Defaults to "maven-central"
  * @param closure This closure will be executed when the Maven <code>settings.xml</code> file was successfully created.
  */
-def settingsWithEnvHome(def nexusCredentials, String cesFQDN, String mirrorNexusPath=defaultMavenCentralRepoName, Closure closure) {
+def settingsWithEnvHome(def nexusCredentials, String cesFQDN, String mirrorNexusPath="maven-central", Closure closure) {
     def currentHome = env.HOME
     settings(nexusCredentials, cesFQDN, currentHome, mirrorNexusPath, closure)
 }
@@ -76,7 +74,7 @@ def settingsWithEnvHome(def nexusCredentials, String cesFQDN, String mirrorNexus
  * @param mirrorNexusPath relative path to a maven central mirror hosted inside a nexus instance. The prefix <code>/nexus/repository</code> will be added automatically. Defaults to "maven-central"
  * @param mvnCallArgs these arguments contain the Maven arguments
  */
-def mvnWithSettings(def nexusCredentials, String cesFQDN, String mirrorNexusPath, String mvnCallArgs) {
+def mvnWithSettings(def nexusCredentials, String cesFQDN, String mirrorNexusPath="maven-central", String mvnCallArgs) {
     def currentHome = env.HOME
     settings(nexusCredentials, cesFQDN, currentHome, mirrorNexusPath) { settingsXml ->
         mvn settingsXml, mvnCallArgs