Skip to content

Commit 9181e1e

Browse files
authored
fix(alerts): quote dnsNames starting with asterisk (#641)
* fix(alerts): quote dnsNames starting with asterisk YAML treats strings starting with asterisk in a special way - that's why the dnsNames with wildcards like *.example.local breaks on helm install Signed-off-by: Richard Tief <richard.tief@sap.com> * chore(alerts): add baseDomain to ci test values Signed-off-by: Richard Tief <richard.tief@sap.com> * chore(alerts): fix ci test value baseDomain Signed-off-by: Richard Tief <richard.tief@sap.com> --------- Signed-off-by: Richard Tief <richard.tief@sap.com>
1 parent b6d4eb5 commit 9181e1e

File tree

5 files changed

+9
-5
lines changed

5 files changed

+9
-5
lines changed

alerts/charts/Chart.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ maintainers:
88
name: alerts
99
sources:
1010
- https://github.com/cloudoperators/greenhouse-extensions
11-
version: 0.19.0
11+
version: 0.19.1
1212
keywords:
1313
- prometheus-alertmanager
1414
dependencies:

alerts/charts/ci/test-values.yaml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
# SPDX-FileCopyrightText: 2024 SAP SE or an SAP affiliate company and Greenhouse contributors
22
# SPDX-License-Identifier: Apache-2.0
3+
global:
4+
greenhouse:
5+
baseDomain: example.com
6+
37
alerts:
48
alertmanager:
59
ingress:

alerts/charts/templates/certmanager.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,6 @@ spec:
8080
{{- end }}
8181
dnsNames:
8282
{{- if .Values.global.greenhouse.baseDomain }}
83-
- {{ printf "*.s%" .Values.global.greenhouse.baseDomain }}
83+
- {{ printf "*.%s" .Values.global.greenhouse.baseDomain | quote }}
8484
{{- end }}
8585
{{- end -}}

alerts/charts/values.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ alerts:
2424
duration: "" # default to be 5y
2525
admissionCert:
2626
duration: "" # default to be 1y
27-
issuerRef:
27+
issuerRef: {}
2828
# name: "issuer"
2929
# kind: "ClusterIssuer"
3030

alerts/plugindefinition.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ kind: PluginDefinition
66
metadata:
77
name: alerts
88
spec:
9-
version: 2.7.0
9+
version: 2.7.1
1010
weight: 0
1111
displayName: Alerts
1212
description: The Alerts Plugin consists of both Prometheus Alertmanager and Supernova, the holistic alert management UI
@@ -15,7 +15,7 @@ spec:
1515
helmChart:
1616
name: alerts
1717
repository: oci://ghcr.io/cloudoperators/greenhouse-extensions/charts
18-
version: 0.19.0
18+
version: 0.19.1
1919
uiApplication:
2020
name: supernova
2121
version: "latest"

0 commit comments

Comments
 (0)