Skip to content

Commit e3556bd

Browse files
authored
fix(kube-monitoring): remove secret reference (#666)
The secret expected to mount is living in the central cluster. Signed-off-by: Richard Tief <richard.tief@sap.com>
1 parent 9789f64 commit e3556bd

File tree

6 files changed

+5
-27
lines changed

6 files changed

+5
-27
lines changed

kube-monitoring/charts/Chart.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ maintainers:
88
name: kube-monitoring
99
sources:
1010
- https://github.com/cloudoperators/greenhouse-extensions
11-
version: 0.24.1
11+
version: 0.24.2
1212
# prometheus-operator app version
1313
appVersion: v0.79.2
1414
keywords:

kube-monitoring/charts/ci/test-values.yaml

Lines changed: 0 additions & 2 deletions
This file was deleted.

kube-monitoring/charts/templates/_alertmanager-config.yaml.tpl

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,8 @@
22
scheme: https
33
{{- if and .Values.alerts.enabled .Values.alerts.alertmanagers.hosts }}
44
tls_config:
5-
{{- if and .Values.alerts.alertmanagers.tlsConfig.cert .Values.alerts.alertmanagers.tlsConfig.key }}
65
cert_file: /etc/prometheus/secrets/tls-prometheus-{{ .Release.Name }}/tls.crt
76
key_file: /etc/prometheus/secrets/tls-prometheus-{{ .Release.Name }}/tls.key
8-
{{- else }}
9-
cert_file: /etc/prometheus/secrets/tls-prometheus-{{ .Release.Namespace }}/tls.crt
10-
key_file: /etc/prometheus/secrets/tls-prometheus-{{ .Release.Namespace }}/tls.key
11-
{{- end }}
127
static_configs:
138
- targets:
149
{{ toYaml .Values.alerts.alertmanagers.hosts | indent 8 }}

kube-monitoring/charts/templates/alertmanager-tls-secret.yaml

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -2,21 +2,9 @@ apiVersion: v1
22
kind: Secret
33
type: Opaque
44
metadata:
5-
name: tls-prometheus-{{ .Release.Name }}-cert
5+
name: tls-prometheus-{{ .Release.Name }}
66
labels:
77
{{- include "kube-prometheus-stack.labels" . | indent 4 }}
88
data:
99
tls.crt: {{ .Values.alerts.alertmanagers.tlsConfig.cert | b64enc | quote }}
1010
tls.key: {{ .Values.alerts.alertmanagers.tlsConfig.key | b64enc | quote }}
11-
12-
{{- if .Values.alerts.dummySecret }}
13-
---
14-
apiVersion: v1
15-
kind: Secret
16-
type: Opaque
17-
metadata:
18-
name: tls-prometheus-{{ .Release.Namespace }}
19-
data:
20-
tls.crt: ""
21-
tls.key: ""
22-
{{- end }}

kube-monitoring/charts/values.yaml

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -300,8 +300,7 @@ kubeMonitoring:
300300
## reflected in the running Pods. To change the secrets mounted into the Prometheus Pods, the object must be deleted and recreated
301301
## with the new list of secrets.
302302
secrets:
303-
- "tls-prometheus-{{ .Release.Name }}-cert"
304-
- "tls-prometheus-{{ .Release.Namespace }}"
303+
- "tls-prometheus-{{ .Release.Name }}"
305304

306305
storageSpec:
307306
volumeClaimTemplate:
@@ -357,8 +356,6 @@ kubernetes-operations:
357356
## Configures Prometheus Alertmanager
358357
alerts:
359358
enabled: false
360-
# Creates a dummy Secret to ensure standalone testing
361-
dummySecret: false
362359
alertmanagers:
363360
hosts: []
364361
## Overrides tls certificate to authenticate with Alertmanager

kube-monitoring/plugindefinition.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,15 +6,15 @@ kind: PluginDefinition
66
metadata:
77
name: kube-monitoring
88
spec:
9-
version: 2.11.0
9+
version: 2.11.1
1010
displayName: Kubernetes monitoring
1111
description: Native deployment and management of Prometheus along with Kubernetes cluster monitoring components.
1212
docMarkDownUrl: https://raw.githubusercontent.com/cloudoperators/greenhouse-extensions/main/kube-monitoring/README.md
1313
icon: https://raw.githubusercontent.com/cloudoperators/greenhouse-extensions/main/kube-monitoring/logo.png
1414
helmChart:
1515
name: kube-monitoring
1616
repository: oci://ghcr.io/cloudoperators/greenhouse-extensions/charts
17-
version: 0.24.1
17+
version: 0.24.2
1818
options:
1919
- name: global.commonLabels
2020
description: Labels to add to all resources. This can be used to add a support group or service to all alerts.

0 commit comments

Comments
 (0)