Skip to content

πŸ› [BUG] - GitHub Action License Header adds license multiple times and not at the start for chart testsΒ #347

@timojohlo

Description

@timojohlo

Priority

(Medium) I'm annoyed but I'll live

Description

Problem Description

Currently the GitHub Action Check & Fix License Header adds multiple license headers to a .yaml file and right after a shebang (#!/) instead of at the start of the file. This affects currently all helm tests in */templates/tests/** that include #!/usr/bin/env bats.

Example

https://github.com/cloudoperators/greenhouse-extensions/blob/542c24d2f139ef32b6fbd6f51f12b98ab4c9c988/opentelemetry/chart/templates/tests/test-opentelemetry-config.yaml

References

https://github.com/apache/skywalking-eyes/blob/3ea9df11bb3a5a85665377d1fd10c02edecf2c40/assets/styles.yaml#L24

Reproduction steps

1. Download license-eye-header here: https://github.com/apache/skywalking-eyes
2. Run `license-eye -c path/to/.github/licenserc.yaml header fix` inside `/tests` folder e.g `/opentelemetry/chart/template/test/`
3. Check affected files

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions