Fix #129: do not silence RuntimeError in dump() (#140)

Author: pitrou

cloudpickle/cloudpickle.py

@@ -262,6 +262,8 @@ def dump(self, obj):
             if 'recursion' in e.args[0]:
                 msg = """Could not pickle object as excessively deep recursion required."""
                 raise pickle.PicklingError(msg)
+            else:
+                raise
 
     def save_memoryview(self, obj):
         self.save(obj.tobytes())

tests/cloudpickle_test.py

@@ -50,6 +50,15 @@
 HAVE_WEAKSET = hasattr(weakref, 'WeakSet')
 
 
+class RaiserOnPickle(object):
+
+    def __init__(self, exc):
+        self.exc = exc
+
+    def __reduce__(self):
+        raise self.exc
+
+
 def pickle_depickle(obj):
     """Helper function to test whether object pickled with cloudpickle can be
     depickled with pickle
@@ -820,6 +829,12 @@ def test_function_pickle_compat_0_4_1(self):
             b'\x14NtR.')
         self.assertEquals(42, cloudpickle.loads(pickled)(42))
 
+    def test_pickle_reraise(self):
+        for exc_type in [Exception, ValueError, TypeError, RuntimeError]:
+            obj = RaiserOnPickle(exc_type("foo"))
+            with pytest.raises((exc_type, pickle.PicklingError)):
+                cloudpickle.dumps(obj)
+
 
 if __name__ == '__main__':
     unittest.main()