-
Notifications
You must be signed in to change notification settings - Fork 183
MTN deterministic co_filename for dynamic code pickling #560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MTN deterministic co_filename for dynamic code pickling #560
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #560 +/- ##
=======================================
Coverage 96.34% 96.35%
=======================================
Files 3 3
Lines 575 576 +1
Branches 121 121
=======================================
+ Hits 554 555 +1
Misses 11 11
Partials 10 10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No idea on how to debug the random failure but I found a typo...
Co-authored-by: Olivier Grisel <[email protected]>
|
The failure is deterministic and only happening on windows and on this branch (see #562 running from master and working). |
This reverts commit 2aff8f2.
|
@tomMoral the bug seems to have disappeared with a more recent version of CPython 3.14 (and after sync with |
|
Let me trigger the CI another time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides the following, LGTM.
Co-authored-by: Olivier Grisel <[email protected]>
|
Feel free to skip the new tests on pypy if they are too slow to run without triggering a timeout. |
|
Ok I skipped the tests on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Set the
co_filenameto<dynamic-code>when pickling the code object to make the payload independent of where the code was defined.TODO:
Fix #538