Skip to content

Conversation

@tomMoral
Copy link
Contributor

@tomMoral tomMoral commented Mar 21, 2025

Set the co_filename to <dynamic-code> when pickling the code object to make the payload independent of where the code was defined.

TODO:

  • add test
  • add changelog

Fix #538

@codecov
Copy link

codecov bot commented Mar 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.35%. Comparing base (7576fff) to head (42caaae).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #560   +/-   ##
=======================================
  Coverage   96.34%   96.35%           
=======================================
  Files           3        3           
  Lines         575      576    +1     
  Branches      121      121           
=======================================
+ Hits          554      555    +1     
  Misses         11       11           
  Partials       10       10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea on how to debug the random failure but I found a typo...

@tomMoral
Copy link
Contributor Author

The failure is deterministic and only happening on windows and on this branch (see #562 running from master and working).
Not sure how to debug either...

@ogrisel
Copy link
Contributor

ogrisel commented Nov 3, 2025

@tomMoral the bug seems to have disappeared with a more recent version of CPython 3.14 (and after sync with master.

@ogrisel
Copy link
Contributor

ogrisel commented Nov 3, 2025

Let me trigger the CI another time.

Copy link
Contributor

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the following, LGTM.

@ogrisel
Copy link
Contributor

ogrisel commented Nov 4, 2025

Feel free to skip the new tests on pypy if they are too slow to run without triggering a timeout.

@tomMoral
Copy link
Contributor Author

tomMoral commented Nov 5, 2025

Ok I skipped the tests on Pypy to avoid making the CI longer for a test on a test utils.
Let me know if anything else is missing.

Copy link
Contributor

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ogrisel ogrisel merged commit f5199fe into cloudpipe:master Nov 5, 2025
25 checks passed
@tomMoral tomMoral deleted the MTN_deterministic_co_filenames branch November 5, 2025 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cloudpickle is not stable in notebooks

3 participants