fix: adjust deprecated lookup function (#16)

* fix: adjust deprecated lookup function

lookup(map, key) was useful in older Terraform versions when maps were sometimes nullable. Direct indexing (map["key"]) is now preferred because it is more readable, Terraform explicitly fails if the key doesn’t exist, and it aligns with standard programming practices

* fix: update credential module location

* fix: adjust datadog_configuration to use git repo

* fix: adjust component creds module path

* fix: revert datadog config provider

* Use repo component reference

* Use repo component reference

* Use repo component reference

* Update provider-datadog.tf

* Use repo component reference

* Update provider-datadog.tf

* Update provider-datadog.tf

---------

Co-authored-by: Igor Rodionov <[email protected]>

Author: RoseSecurity

src/main.tf

@@ -12,8 +12,8 @@ locals {
         lookup(v, "name_prefix", "/aws/"),
         module.log_group_prefix.id,
         module.log_group_prefix.delimiter,
-        lookup(v, "name_suffix")
-      ) : lookup(v, "name")
+        v["name_suffix"]
+      ) : v["name"]
       filter_pattern : lookup(v, "filter_pattern", "")
     }
   }

src/provider-datadog.tf

@@ -1,5 +1,5 @@
 module "datadog_configuration" {
-  source                  = "../datadog-configuration/modules/datadog_keys"
+  source                  = "github.com/cloudposse-terraform-components/aws-datadog-credentials?ref=tags/v1.535.1"
   enabled                 = true
   context                 = module.this.context
   global_environment_name = var.datadog_configuration_environment