Skip to content

Commit fad0fad

Browse files
authored
[alb-controller] Make default_ingress_ip_address_type default to ipv4 (cloudposse/terraform-aws-components#1070)
1 parent 0c170cb commit fad0fad

File tree

3 files changed

+18
-3
lines changed

3 files changed

+18
-3
lines changed

src/CHANGELOG.md

Lines changed: 16 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,19 @@
1-
## PR [#821](https://github.com/cloudposse/terraform-aws-components/pull/821)
1+
## PR 1070
2+
3+
PR [#1070](https://github.com/cloudposse/terraform-aws-components/pull/1070)
4+
5+
Change default for `default_ingress_ip_address_type` from `dualstack` to `ipv4`. When `dualstack` is configured, the
6+
Ingress will fail if the VPC does not have an IPv6 CIDR block, which is still a common case. When `ipv4` is configured,
7+
the Ingress will work with only an IPv4 CIDR block, and simply will not use IPv6 if it exists. This makes `ipv4` the
8+
more conservative default.
9+
10+
## Release 1.432.0
11+
12+
Better support for Kubeconfig authentication
13+
14+
## Release 1.289.1
15+
16+
PR [#821](https://github.com/cloudposse/terraform-aws-components/pull/821)
217

318
### Update IAM Policy and Change How it is Managed
419

src/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ components:
109109
| <a name="input_default_ingress_class_name"></a> [default\_ingress\_class\_name](#input\_default\_ingress\_class\_name) | Class name for default ingress | `string` | `"default"` | no |
110110
| <a name="input_default_ingress_enabled"></a> [default\_ingress\_enabled](#input\_default\_ingress\_enabled) | Set `true` to deploy a default IngressClass. There should only be one default per cluster. | `bool` | `true` | no |
111111
| <a name="input_default_ingress_group"></a> [default\_ingress\_group](#input\_default\_ingress\_group) | Group name for default ingress | `string` | `"common"` | no |
112-
| <a name="input_default_ingress_ip_address_type"></a> [default\_ingress\_ip\_address\_type](#input\_default\_ingress\_ip\_address\_type) | IP address type for default ingress, one of `ipv4` or `dualstack`. | `string` | `"dualstack"` | no |
112+
| <a name="input_default_ingress_ip_address_type"></a> [default\_ingress\_ip\_address\_type](#input\_default\_ingress\_ip\_address\_type) | IP address type for default ingress, one of `ipv4` or `dualstack`. | `string` | `"ipv4"` | no |
113113
| <a name="input_default_ingress_load_balancer_attributes"></a> [default\_ingress\_load\_balancer\_attributes](#input\_default\_ingress\_load\_balancer\_attributes) | A list of load balancer attributes to apply to the default ingress load balancer.<br>See [Load Balancer Attributes](https://docs.aws.amazon.com/elasticloadbalancing/latest/application/application-load-balancers.html#load-balancer-attributes). | `list(object({ key = string, value = string }))` | `[]` | no |
114114
| <a name="input_default_ingress_scheme"></a> [default\_ingress\_scheme](#input\_default\_ingress\_scheme) | Scheme for default ingress, one of `internet-facing` or `internal`. | `string` | `"internet-facing"` | no |
115115
| <a name="input_delimiter"></a> [delimiter](#input\_delimiter) | Delimiter to be used between ID elements.<br>Defaults to `-` (hyphen). Set to `""` to use no delimiter at all. | `string` | `null` | no |

src/variables.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ variable "default_ingress_scheme" {
120120
variable "default_ingress_ip_address_type" {
121121
type = string
122122
description = "IP address type for default ingress, one of `ipv4` or `dualstack`."
123-
default = "dualstack"
123+
default = "ipv4"
124124

125125
validation {
126126
condition = contains(["ipv4", "dualstack"], var.default_ingress_ip_address_type)

0 commit comments

Comments
 (0)