Skip to content

Commit e13e1e5

Browse files
committed
Fix defer order
1 parent 2e4e389 commit e13e1e5

File tree

1 file changed

+6
-7
lines changed

1 file changed

+6
-7
lines changed

test/component_test.go

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,12 @@ func (s *ComponentSuite) TestBasic() {
4141
delegatedDomainName := atmos.Output(s.T(), dnsDelegatedOptions, "default_domain_name")
4242
defaultDNSZoneId := atmos.Output(s.T(), dnsDelegatedOptions, "default_dns_zone_id")
4343

44+
defer func() {
45+
if err := awsHelper.CleanDNSZoneID(s.T(), context.Background(), defaultDNSZoneId, awsRegion); err != nil {
46+
fmt.Printf("Error cleaning DNS zone %s: %v\n", defaultDNSZoneId, err)
47+
}
48+
}()
49+
4450
randomID := strings.ToLower(random.UniqueId())
4551

4652
namespace := fmt.Sprintf("external-dns-%s", randomID)
@@ -129,7 +135,6 @@ func (s *ComponentSuite) TestBasic() {
129135

130136

131137
stopChannel := make(chan struct{})
132-
133138
informer.AddEventHandler(cache.ResourceEventHandlerFuncs{
134139
UpdateFunc: func(oldObj, newObj interface{}) {
135140
_, ok := oldObj.(*unstructured.Unstructured)
@@ -187,12 +192,6 @@ func (s *ComponentSuite) TestBasic() {
187192
delegatedNSRecord := awsTerratest.GetRoute53Record(s.T(), defaultDNSZoneId, dnsRecordHostName, "A", awsRegion)
188193
assert.Equal(s.T(), fmt.Sprintf("%s.", dnsRecordHostName), *delegatedNSRecord.Name)
189194

190-
defer func() {
191-
if err := awsHelper.CleanDNSZoneID(s.T(), context.Background(), defaultDNSZoneId, awsRegion); err != nil {
192-
fmt.Printf("Error cleaning DNS zone %s: %v\n", defaultDNSZoneId, err)
193-
}
194-
}()
195-
196195
s.DriftTest(component, stack, &inputs)
197196
}
198197

0 commit comments

Comments
 (0)