Add component tests #17

goruha · 2025-03-28T21:32:17Z

What

Add basic component test
Add disabled component test
Test component drifting
Add any additional use case tests

Why

Test basic component features
Verify that the component does not create any resources when input enabled: false set
Verify that the component does not drift on a second run with the same inputs
Add test for any additional than basic use cases for the component

References

Summary by CodeRabbit

Chores
- Streamlined configuration management by removing redundant dependency imports, simplifying the setup process.
Bug Fixes
- Increased timeout duration for waiting on the readiness of ExternalSecret resources, enhancing reliability in tests.
- Improved test flow and clarity by adding comments and ensuring proper resource checks during deployment.

coderabbitai · 2025-03-28T21:32:25Z

Walkthrough

The changes involve the removal of three import statements from the configuration file located at test/fixtures/stacks/orgs/default/test/tests.yaml. The imports for catalog/dns-primary, catalog/dns-delegated, and catalog/eks-alb-controller have been deleted, while other imports remain intact. Additionally, in test/component_test.go, the instantiation of the dynamic informer factory has been updated to include a timeout duration of one minute and a namespace filter, alongside the addition of a new deployment for the Atmos component.

Changes

File Path	Change Summary
test/…/orgs/default/test/tests.yaml	Removed three import statements: `catalog/dns-primary`, `catalog/dns-delegated`, and `catalog/eks-alb-controller`. Other import statements remain unchanged.
test/component_test.go	Updated `TestBasic` function with a new import for `corev1`, modified dynamic informer factory instantiation, added a deployment for `ClusterSecretStore`, and included a `defer close(stopChannel)` statement.

Poem

I'm hopping through configs with a joyful heart,
Removing excess lines to perfect my art.
Three imports gone in a swift, clean hop,
My code garden blooms—no clutter to stop.
With whiskered sniffs and a cheerful skip, I celebrate this streamlined script!

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 21409b9 and e9a3108.

📒 Files selected for processing (1)

test/component_test.go (5 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

test/component_test.go

⏰ Context from checks skipped due to timeout of 90000ms (3)

GitHub Check: Mergify Merge Protections
GitHub Check: Mergify Merge Protections
GitHub Check: Summary

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai plan to trigger planning for file edits and PR creation.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

goruha · 2025-03-28T21:32:37Z

/terratest

mergify · 2025-03-28T21:32:54Z

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Require terratest

Wonderful, this rule succeeded.

This rule require terratest status

check-success = test/terratest

goruha · 2025-03-31T11:15:28Z

/terratest

goruha · 2025-03-31T12:10:05Z

/terratest

…s/aws-eks-external-secrets-operator into add-tests * 'add-tests' of github.com:cloudposse-terraform-components/aws-eks-external-secrets-operator: chore: update README.md (#16)

goruha · 2025-03-31T12:55:07Z

/terratest

goruha · 2025-03-31T21:20:04Z

/terratest

github-actions · 2025-06-28T10:06:15Z

These changes were released in v1.536.0.

Fix tests

89d529a

goruha requested review from a team as code owners March 28, 2025 21:32

goruha linked an issue Mar 28, 2025 that may be closed by this pull request

Add component tests #15

Closed

4 tasks

Merge branch 'main' into add-tests

5f2ed53

goruha added 3 commits March 31, 2025 14:53

Extend secret ready wait time

501f18b

Extend secret ready wait time

ce55a83

Merge branch 'add-tests' of github.com:cloudposse-terraform-component…

21409b9

…s/aws-eks-external-secrets-operator into add-tests * 'add-tests' of github.com:cloudposse-terraform-components/aws-eks-external-secrets-operator: chore: update README.md (#16)

Fix cluster store resource

e9a3108

goruha merged commit d3e6e42 into main Apr 1, 2025
19 checks passed

goruha deleted the add-tests branch April 1, 2025 08:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Add component tests #17

Add component tests #17

Uh oh!

goruha commented Mar 28, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Mar 28, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

goruha commented Mar 28, 2025

Uh oh!

mergify bot commented Mar 28, 2025 •

edited

Loading

Uh oh!

goruha commented Mar 31, 2025

Uh oh!

goruha commented Mar 31, 2025

Uh oh!

goruha commented Mar 31, 2025

Uh oh!

goruha commented Mar 31, 2025

Uh oh!

Uh oh!

github-actions bot commented Jun 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Add component tests #17

Add component tests #17

Uh oh!

Conversation

goruha commented Mar 28, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What

Why

References

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Mar 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

goruha commented Mar 28, 2025

Uh oh!

mergify bot commented Mar 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge Protections

🟢 Require terratest

Uh oh!

goruha commented Mar 31, 2025

Uh oh!

goruha commented Mar 31, 2025

Uh oh!

goruha commented Mar 31, 2025

Uh oh!

goruha commented Mar 31, 2025

Uh oh!

Uh oh!

github-actions bot commented Jun 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

goruha commented Mar 28, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Mar 28, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

mergify bot commented Mar 28, 2025 •

edited

Loading