Add Partner Central Permission Sets mixin#59
Conversation
This adds a new mixin file with 8 AWS Partner Central permission sets: - PartnerCentralFullAccess - PartnerCentralAccountMgmt - PartnerCentralOpportunityMgmt - PartnerCentralSandboxAccess - PartnerCentralResourceSnapshot - PartnerCentralChannelMgmt - PartnerCentralHandshakeMgmt - PartnerCentralMarketingMgmt These permission sets enable AWS Partner Central integration and APN program management. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
|
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. 📝 WalkthroughWalkthroughAdds a Terraform locals block Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 844a6dcc1a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Adds comprehensive documentation for using mixins with the aws-identity-center component: - How to vendor mixins via component.yaml - How to vendor mixins via vendor.yaml - How to activate permission sets using additional-permission-sets_override.tf - Pattern for creating custom mixins - Detailed examples for all approaches Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
|
Important Do not edit the Please update the Could you fix it @Benbentwo? 🙏 |
Documentation AddedI've added comprehensive documentation in mixins/README.md that covers: Usage OptionsOption 1: Vendor via component.yaml # components/terraform/aws-sso/component.yaml
spec:
source:
uri: github.com/cloudposse-terraform-components/aws-identity-center.git//src?ref={{ .Version }}
version: 1.0.0
mixins:
- uri: github.com/cloudposse-terraform-components/aws-identity-center.git//mixins/policy-PartnerCentral.tf?ref={{ .Version }}
version: 1.0.0
filename: policy-PartnerCentral.tfOption 2: Vendor via vendor.yaml (for centralized vendoring configuration) Option 3: Manual copy (for quick testing) Activating the Permission SetsAfter vendoring, create or update # components/terraform/aws-sso/additional-permission-sets_override.tf
locals {
overridable_additional_permission_sets = concat(
local.partner_central_permission_sets,
# Add other permission set locals here as needed
)
}Then run: atmos vendor pull -c aws-ssoThe mixin defines See the full documentation for complete examples and patterns for creating your own custom mixins. |
- Add comprehensive "Using Mixins" section to README.yaml - Document how to vendor mixins via component.yaml and vendor.yaml - Explain how to activate permission sets using additional-permission-sets_override.tf - Provide examples for creating custom mixins - Regenerate README.md using atmos docs generate readme Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
|
These changes were released in v1.540.2. |
Summary
policy-PartnerCentral.tfwith 8 AWS Partner Central permission setsPermission Sets Included
Test plan
🤖 Generated with Claude Code
Summary by CodeRabbit
Chores
Documentation
✏️ Tip: You can customize this high-level summary in your review settings.