Conversation
|
/terratest |
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟠 Require terratestWaiting checks:
|
|
Heads up! This pull request looks stale. It will be closed soon, if there are no new commits. ⏳ |
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Heads up! This pull request looks stale. It will be closed soon, if there are no new commits. ⏳ |
|
Heads up! This pull request looks stale. It will be closed soon, if there are no new commits. ⏳ |
|
Heads up! This pull request looks stale. It will be closed soon, if there are no new commits. ⏳ |
|
Heads up! This pull request looks stale. It will be closed soon, if there are no new commits. ⏳ |
|
Heads up! This pull request looks stale. It will be closed soon, if there are no new commits. ⏳ |
|
Heads up! This pull request looks stale. It will be closed soon, if there are no new commits. ⏳ |
b8bb834 to
b15ce30
Compare
b15ce30 to
320dbe9
Compare
320dbe9 to
2060f1d
Compare
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 Require terratestWonderful, this rule succeeded.This rule require terratest status
|
|
/terratest |
|
There are no real tests for this component. So we set terratest statuses to successful execution without running any tests |
|
These changes were released in v1.535.1. |
This PR contains the following updates:
0.95.0->0.97.00.92.0->0.97.0Release Notes
cloudposse/terraform-aws-cloudfront-s3-cdn (cloudposse/cloudfront-s3-cdn/aws)
v0.97.0Compare Source
🚀 Enhancements
feat: Add support for custom Lambda@Edge policies @jwadolowski (#333)
what
Execution role associated with Lambda@Edge comes with a hardcoded policy that enables write access to CloudWatch logs. This PR adds support for additional policies. It was implemented in a similar fashion to
additional_bucket_policyfrom the parent module.why
It's a fairly common situation that a Lambda@Edge function needs access to other AWS services/resources than CloudWatch logs.
aws_lambda_function'sroleargument expects a single role ARN, therefore the only reasonable option is to append new policy statements to the IAM role created in scope of this module.references
closes #261
v0.96.2Compare Source
🚀 Enhancements
Set allowed and cache methods as non nullable @travis-reed (#324)
what
Set allowed_methods and cached_methods as non nullable
Setting nullable to false ensures that the variable value will never be null within the module. If nullable is false and the variable has a default value, then Terraform uses the default when a module input argument is null.
why
I want to be able to sometimes call this module with explicit
allowed_methodsandcached_methodsand sometimes just use the module defaults.As it stands, I cannot do that without making my default value match your default value. It would be better for the module to use its defaults when I pass in
nullRight now I am hitting
Which I can work around by setting a default on my side, but it isn't ideal behavior
references
Additional Notes
I wouldn't consider this a breaking change. Today, the behavior if you pass in
nullas the argument to the module you will get a failure as shown above. This makes passing innullpossible without negatively impacting existing users.Make sure tags are associated with Lambda functions(#332)
why
tagsargument is not set at all which results in an empty tag list.references
https://github.com/cloudposse/terraform-aws-cloudfront-s3-cdn/blob/v0.96.1/modules/lambda%40edge/main.tf#L78-L86
v0.96.1Compare Source
🚀 Enhancements
memory and timeout vars for lambda@edge @mihaiplesa (#330)
what
Allow to configure memory size and timeout for Lambda@Edge module.
why
These fields are not configurable now.
references
Resolves https://github.com/cloudposse/terraform-aws-cloudfront-s3-cdn/issues/331
v0.96.0Compare Source
Adding origin_access_control_id to custom_origins @jjchiw (#326)
Adding Origin Access Control Id to Custom Originswhat
Custom Origins didn't have
Origin Access ControlImplements this infrastructure
https://aws.amazon.com/blogs/networking-and-content-delivery/image-optimization-using-amazon-cloudfront-and-aws-lambda/
why
Custom Origins didn't have
Origin Access Controlif we wanted to invoke alambdawe were not able to do itreferences
Summary by CodeRabbit
New Features
origin_access_control_id.custom_originsands3_originsto include access control ID.Bug Fixes
Documentation
v0.95.1Compare Source
Add support for origin-access-control @rankin-tr (#319)
what
var.origin_access_typeto enable Origin Access Identity or Origina Access Control policyaws_cloudfront_origin_access_control.defaultresourceorigin_access_control_idargument to origin config onaws_cloudfront_distribution.defaultwhy
references
🤖 Automatic Updates
Migrate new test account @osterman (#322)
what
.github/settings.yml.github/chatops.ymlfileswhy
.github/settings.ymlfrom org level to getterratestenvironmenttestaccountReferences
Update .github/settings.yml @osterman (#321)
what
.github/settings.yml.github/auto-release.ymlfileswhy
.github/settings.ymlfrom org levelreferences
Update .github/settings.yml @osterman (#320)
what
.github/settings.yml.github/auto-release.ymlfileswhy
.github/settings.ymlfrom org levelreferences
Update .github/settings.yml @osterman (#312)
what
.github/settings.yml.github/auto-release.ymlfileswhy
.github/settings.ymlfrom org levelreferences
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR was generated by Mend Renovate. View the repository job log.