Commit 4648265
Update
* update to dynamic-subnets v3
* Add all missing outputs from dynamic-subnets v3.0.0 module
Added 14 new outputs to expose all capabilities from terraform-aws-dynamic-subnets v3.0.0:
**Subnet Outputs:**
- public_subnet_arns - ARNs of public subnets
- private_subnet_arns - ARNs of private subnets
- public_subnet_ipv6_cidrs - IPv6 CIDR blocks for public subnets
- private_subnet_ipv6_cidrs - IPv6 CIDR blocks for private subnets
**Network ACL Outputs:**
- public_network_acl_id - Network ACL ID for public subnets
- private_network_acl_id - Network ACL ID for private subnets
**NAT Outputs:**
- nat_instance_ami_id - AMI ID used by NAT instances
- nat_ips - Elastic IP addresses in use by NAT
- nat_eip_allocation_ids - EIP allocation IDs for NAT
**Availability Zone Outputs:**
- availability_zone_ids - AZ IDs where subnets were created
- az_private_route_table_ids_map - Map of AZ to private route table IDs
- az_public_route_table_ids_map - Map of AZ to public route table IDs
**New v3.0.0 Stats Outputs (with NAT Gateway IDs):**
- named_private_subnets_stats_map - Map of private subnet names to stats objects including NAT Gateway ID that the subnet routes to
- named_public_subnets_stats_map - Map of public subnet names to stats objects including NAT Gateway ID in the subnet
These outputs enable full access to module capabilities including:
- NAT Gateway ID references for Network Firewall routing
- IPv6 subnet configuration
- Network ACL management
- Detailed subnet-to-NAT mapping for cost optimization
Total outputs: 33 → 47 (+14)
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
* update to dynamic-subnets v3
* Fix CodeRabbit review issues
**PRD Documentation Fixes:**
- Replace hard tabs with 2-space indentation in code blocks (lines 217-219)
- Format bare URLs as proper Markdown links in References section
- Fix grammar: "easy to understand" → "easy-to-understand"
**README Regeneration:**
- Regenerate README.md and src/README.md from README.yaml using `atmos readme`
- Ensures generated files are in sync with source YAML
- Follows CloudPosse convention: never edit generated READMEs manually
**Changes:**
- docs/prd/upgrade-to-dynamic-subnets-v3.md: Fixed formatting and Markdown linting issues
- README.md: Regenerated from README.yaml
- src/README.md: Regenerated from README.yaml
Addresses CodeRabbit feedback on PR #70.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
* Address CodeRabbit feedback: Document AWS Provider v5.0+ breaking change
**Breaking Change Documentation:**
This commit addresses critical CodeRabbit feedback regarding the AWS Provider
version requirement change, which is a breaking change that was not clearly
documented in the original PR.
**Changes Made:**
1. **PRD (docs/prd/upgrade-to-dynamic-subnets-v3.md):**
- Added prominent "dynamic-subnets module to v3 (#70)1 parent 77fb0ba commit 4648265
File tree
16 files changed
+2339
-276
lines changed- docs/prd
- src
- test
- fixtures/stacks
- catalog/usecase
- orgs/default/test
16 files changed
+2339
-276
lines changedSome generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
7 | | - | |
8 | | - | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
9 | 24 | | |
10 | 25 | | |
11 | 26 | | |
12 | 27 | | |
13 | | - | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
14 | 31 | | |
15 | 32 | | |
16 | | - | |
| 33 | + | |
17 | 34 | | |
18 | 35 | | |
19 | 36 | | |
| |||
38 | 55 | | |
39 | 56 | | |
40 | 57 | | |
41 | | - | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
42 | 61 | | |
43 | 62 | | |
44 | 63 | | |
| 64 | + | |
45 | 65 | | |
46 | 66 | | |
47 | 67 | | |
| |||
56 | 76 | | |
57 | 77 | | |
58 | 78 | | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
| 212 | + | |
| 213 | + | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
59 | 232 | | |
60 | 233 | | |
61 | 234 | | |
62 | 235 | | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
| 241 | + | |
| 242 | + | |
| 243 | + | |
| 244 | + | |
63 | 245 | | |
64 | 246 | | |
65 | 247 | | |
66 | 248 | | |
| 249 | + | |
| 250 | + | |
| 251 | + | |
| 252 | + | |
| 253 | + | |
67 | 254 | | |
68 | 255 | | |
69 | 256 | | |
70 | 257 | | |
71 | 258 | | |
| 259 | + | |
| 260 | + | |
72 | 261 | | |
73 | 262 | | |
74 | 263 | | |
| |||
86 | 275 | | |
87 | 276 | | |
88 | 277 | | |
| 278 | + | |
| 279 | + | |
| 280 | + | |
| 281 | + | |
| 282 | + | |
| 283 | + | |
| 284 | + | |
| 285 | + | |
| 286 | + | |
| 287 | + | |
| 288 | + | |
| 289 | + | |
89 | 290 | | |
0 commit comments