test(cmd): add unit tests for editorconfig validation logic

Add comprehensive unit tests for the editorconfig validation command,
including dry-run logic, version checking, and integration with atmos
configuration. Tests cover config path parsing, flag overrides, and
various config scenarios to ensure robust behavior.

Author: RoseSecurity

cmd/validate_editorconfig_test.go

@@ -3,9 +3,12 @@ package cmd
 import (
 	"testing"
 
+	"github.com/editorconfig-checker/editorconfig-checker/v3/pkg/config"
 	"github.com/spf13/cobra"
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
+
+	"github.com/cloudposse/atmos/pkg/schema"
 )
 
 // TestParseConfigPaths tests the pure parseConfigPaths function.
@@ -70,3 +73,213 @@ func TestInitConfig(t *testing.T) {
 	// Call function with no assertions - test passes if no panic occurs.
 	initializeConfig(editorConfigCmd)
 }
+
+// TestRunMainLogicDryRun tests the dry-run path in runMainLogic.
+func TestRunMainLogicDryRun(t *testing.T) {
+	// Save original state.
+	originalConfig := currentConfig
+	originalCliConfig := cliConfig
+	defer func() {
+		currentConfig = originalConfig
+		cliConfig = originalCliConfig
+	}()
+
+	// Create a minimal config for dry-run mode.
+	cfg := config.NewConfig([]string{})
+	cfg.DryRun = true
+	currentConfig = cfg
+	cliConfig = config.Config{DryRun: true}
+
+	// This should not panic and should list files (if any match).
+	// In dry-run mode, runMainLogic just lists files without validation.
+	runMainLogic()
+}
+
+// TestCheckVersion tests the version checking logic.
+func TestCheckVersion(t *testing.T) {
+	tests := []struct {
+		name        string
+		config      config.Config
+		expectError bool
+	}{
+		{
+			name: "no config file exists",
+			config: config.Config{
+				Path:    "/nonexistent/path",
+				Version: "",
+			},
+			expectError: false,
+		},
+		{
+			name: "empty version in config",
+			config: config.Config{
+				Path:    ".",
+				Version: "",
+			},
+			expectError: false,
+		},
+		{
+			name: "version mismatch",
+			config: config.Config{
+				Path:    ".", // Current directory exists
+				Version: "999.999.999",
+			},
+			expectError: true,
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			err := checkVersion(tt.config)
+			if tt.expectError {
+				assert.Error(t, err)
+			} else {
+				assert.NoError(t, err)
+			}
+		})
+	}
+}
+
+// TestReplaceAtmosConfigInConfig tests that atmos config values are properly applied.
+func TestReplaceAtmosConfigInConfig(t *testing.T) {
+	// Reset module-level variables before test.
+	originalConfigFilePaths := configFilePaths
+	originalTmpExclude := tmpExclude
+	originalInitEditorConfig := initEditorConfig
+	originalCliConfig := cliConfig
+	defer func() {
+		configFilePaths = originalConfigFilePaths
+		tmpExclude = originalTmpExclude
+		initEditorConfig = originalInitEditorConfig
+		cliConfig = originalCliConfig
+	}()
+
+	tests := []struct {
+		name        string
+		atmosConfig schema.AtmosConfiguration
+		flagChanged map[string]bool
+		setup       func(*cobra.Command)
+		validate    func(t *testing.T)
+	}{
+		{
+			name: "applies config file paths from atmos config",
+			atmosConfig: schema.AtmosConfiguration{
+				Validate: schema.Validate{
+					EditorConfig: schema.EditorConfig{
+						ConfigFilePaths: []string{".custom-editorconfig"},
+					},
+				},
+			},
+			validate: func(t *testing.T) {
+				assert.Equal(t, []string{".custom-editorconfig"}, configFilePaths)
+			},
+		},
+		{
+			name: "applies exclude patterns from atmos config",
+			atmosConfig: schema.AtmosConfiguration{
+				Validate: schema.Validate{
+					EditorConfig: schema.EditorConfig{
+						Exclude: []string{"vendor/**", "node_modules/**"},
+					},
+				},
+			},
+			validate: func(t *testing.T) {
+				assert.Equal(t, "vendor/**,node_modules/**", tmpExclude)
+			},
+		},
+		{
+			name: "applies init flag from atmos config",
+			atmosConfig: schema.AtmosConfiguration{
+				Validate: schema.Validate{
+					EditorConfig: schema.EditorConfig{
+						Init: true,
+					},
+				},
+			},
+			validate: func(t *testing.T) {
+				assert.True(t, initEditorConfig)
+			},
+		},
+		{
+			name: "applies ignore defaults from atmos config",
+			atmosConfig: schema.AtmosConfiguration{
+				Validate: schema.Validate{
+					EditorConfig: schema.EditorConfig{
+						IgnoreDefaults: true,
+					},
+				},
+			},
+			validate: func(t *testing.T) {
+				assert.True(t, cliConfig.IgnoreDefaults)
+			},
+		},
+		{
+			name: "applies dry run from atmos config",
+			atmosConfig: schema.AtmosConfiguration{
+				Validate: schema.Validate{
+					EditorConfig: schema.EditorConfig{
+						DryRun: true,
+					},
+				},
+			},
+			validate: func(t *testing.T) {
+				assert.True(t, cliConfig.DryRun)
+			},
+		},
+		{
+			name: "applies disable flags from atmos config",
+			atmosConfig: schema.AtmosConfiguration{
+				Validate: schema.Validate{
+					EditorConfig: schema.EditorConfig{
+						DisableTrimTrailingWhitespace: true,
+						DisableEndOfLine:              true,
+						DisableInsertFinalNewline:     true,
+						DisableIndentation:            true,
+						DisableIndentSize:             true,
+						DisableMaxLineLength:          true,
+					},
+				},
+			},
+			validate: func(t *testing.T) {
+				assert.True(t, cliConfig.Disable.TrimTrailingWhitespace)
+				assert.True(t, cliConfig.Disable.EndOfLine)
+				assert.True(t, cliConfig.Disable.InsertFinalNewline)
+				assert.True(t, cliConfig.Disable.Indentation)
+				assert.True(t, cliConfig.Disable.IndentSize)
+				assert.True(t, cliConfig.Disable.MaxLineLength)
+			},
+		},
+		{
+			name: "applies no color from atmos config",
+			atmosConfig: schema.AtmosConfiguration{
+				Settings: schema.AtmosSettings{
+					Terminal: schema.Terminal{
+						NoColor: true,
+					},
+				},
+			},
+			validate: func(t *testing.T) {
+				assert.True(t, cliConfig.NoColor)
+			},
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			// Reset state.
+			configFilePaths = nil
+			tmpExclude = ""
+			initEditorConfig = false
+
+			cmd := &cobra.Command{}
+			addPersistentFlags(cmd)
+
+			if tt.setup != nil {
+				tt.setup(cmd)
+			}
+
+			replaceAtmosConfigInConfig(cmd, tt.atmosConfig)
+			tt.validate(t)
+		})
+	}
+}