Skip to content

Commit 92353fc

Browse files
rmandziarz-spotonostermangoruha
authored
Fix kibana_endpoint in aws_opensearch_domain for AWS provider v6 (#206)
* Fix kibana_endpoint in aws_opensearch_domain for AWS provider v6 * Bump required version for AWS provider to 5.0 * Use new test DNS Zone ID * Update examples_complete_test.go * Update examples_complete_test.go --------- Co-authored-by: Erik Osterman (CEO @ Cloud Posse) <[email protected]> Co-authored-by: Igor Rodionov <[email protected]>
1 parent cb2497e commit 92353fc

File tree

4 files changed

+5
-5
lines changed

4 files changed

+5
-5
lines changed

examples/complete/fixtures.us-east-2.tfvars

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ ebs_volume_size = 20
3030

3131
create_iam_service_linked_role = false
3232

33-
dns_zone_id = "Z3SO0TKDDQ0RGG"
33+
dns_zone_id = "Z0880904EUMUUAAGCA17"
3434

3535
kibana_hostname_enabled = true
3636

main.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ locals {
88
aws_service_domain_endpoint = coalesce(join("", aws_elasticsearch_domain.default[*].endpoint), join("", aws_opensearch_domain.default[*].endpoint))
99
aws_service_domain_id = coalesce(join("", aws_elasticsearch_domain.default[*].domain_id), join("", aws_opensearch_domain.default[*].domain_id))
1010
aws_service_domain_name = coalesce(join("", aws_elasticsearch_domain.default[*].domain_name), join("", aws_opensearch_domain.default[*].domain_name))
11-
aws_service_domain_kibana_endpoint = coalesce(join("", aws_elasticsearch_domain.default[*].kibana_endpoint), join("", aws_opensearch_domain.default[*].kibana_endpoint))
11+
aws_service_domain_kibana_endpoint = coalesce(join("", aws_elasticsearch_domain.default[*].kibana_endpoint), join("", aws_opensearch_domain.default[*].dashboard_endpoint))
1212
}
1313

1414
module "user_label" {

test/src/examples_complete_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,12 +54,12 @@ func TestExamplesComplete(t *testing.T) {
5454
// Run `terraform output` to get the value of an output variable
5555
domainHostname := terraform.Output(t, terraformOptions, "domain_hostname")
5656
// Verify we're getting back the outputs we expect
57-
assert.Equal(t, "eg-test-es-test-"+randId+".testing.cloudposse.co", domainHostname)
57+
assert.Equal(t, "eg-test-es-test-"+randId+".modules.cptest.test-automation.app", domainHostname)
5858

5959
// Run `terraform output` to get the value of an output variable
6060
kibanaHostname := terraform.Output(t, terraformOptions, "kibana_hostname")
6161
// Verify we're getting back the outputs we expect
62-
assert.Equal(t, "eg-test-es-test-"+randId+"-kibana.testing.cloudposse.co", kibanaHostname)
62+
assert.Equal(t, "eg-test-es-test-"+randId+"-kibana.modules.cptest.test-automation.app", kibanaHostname)
6363

6464
// Run `terraform output` to get the value of an output variable
6565
domainEndpoint := terraform.Output(t, terraformOptions, "domain_endpoint")

versions.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ terraform {
44
required_providers {
55
aws = {
66
source = "hashicorp/aws"
7-
version = ">= 3.35.0"
7+
version = ">= 5.0"
88
}
99
}
1010
}

0 commit comments

Comments
 (0)