Parameterize access policies json for more flexibility (3rd try) #198
Conversation
|
Hi @osterman ! Sorry to ping you and thank you for all the work on this and other modules 🙇 Do you think that this change on the module makes sense? I've been trying to have it merged for a long time now 😅 Thank you and all the best! |
|
@bmbferreira Hello. 
|
|
💥 This pull request now has conflicts. Could you fix it @bmbferreira? 🙏 |
|
@bmbferreira Thanks for the contribution. |
… try) (#210) * parameterize access policies json for more flexibility * Auto Format * Pull changes from bmbferreira/terraform-aws-elasticsearch/tree/master --------- Co-authored-by: Bruno Ferreira <[email protected]> Co-authored-by: cloudpossebot <[email protected]>
Sorry for the delay replying to you. Thanks a lot @goruha for finally merging these changes. 🙇♂️ |
what
Adds a new parameter to be able to pass a json string with a custom access policy to set for the elasticsearch.
why
In my opinion, the access policies are too "opinionated" on this module, especially when it is on "vpc mode". I think it should be more flexible and allow to customize it however we want and not having it based on the iam_role_arn variable.
references
N/A
P.S.: This is already the 3rd time I'm trying to have this new parameter accepted. Please take a look at it this time 🙇 thank you.
Previous tries: