From 50152edaa64e4088d54cf9cd32e4cc91cfabb447 Mon Sep 17 00:00:00 2001 From: pkapoor-blackline Date: Tue, 27 May 2025 12:23:32 -0400 Subject: [PATCH 1/3] Added create_native_delta_table to dynamodb_target, in main.tf and variables.tf --- modules/glue-crawler/main.tf | 7 ++++--- modules/glue-crawler/variables.tf | 7 ++++--- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/modules/glue-crawler/main.tf b/modules/glue-crawler/main.tf index 18271b2..2b01924 100644 --- a/modules/glue-crawler/main.tf +++ b/modules/glue-crawler/main.tf @@ -29,9 +29,10 @@ resource "aws_glue_crawler" "this" { for_each = var.delta_target != null ? var.delta_target : [] content { - connection_name = delta_target.value.connection_name - delta_tables = delta_target.value.delta_tables - write_manifest = delta_target.value.write_manifest + connection_name = delta_target.value.connection_name + create_native_delta_table = delta_target.value.create_native_delta_table + delta_tables = delta_target.value.delta_tables + write_manifest = delta_target.value.write_manifest } } diff --git a/modules/glue-crawler/variables.tf b/modules/glue-crawler/variables.tf index 655792f..5eb08ae 100644 --- a/modules/glue-crawler/variables.tf +++ b/modules/glue-crawler/variables.tf @@ -104,9 +104,10 @@ variable "catalog_target" { variable "delta_target" { type = list(object({ - connection_name = string - delta_tables = list(string) - write_manifest = bool + connection_name = string + create_native_delta_table = bool + delta_tables = list(string) + write_manifest = bool })) description = "List of nested Delta target arguments." default = null From 0fbd9f63484780d2b5d5ee71465f70fa2b4fe753 Mon Sep 17 00:00:00 2001 From: pkapoor-blackline <167803037+pkapoor-blackline@users.noreply.github.com> Date: Wed, 6 Aug 2025 17:33:53 -0400 Subject: [PATCH 2/3] create_native_delta_table should be optional bool --- modules/glue-crawler/variables.tf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/glue-crawler/variables.tf b/modules/glue-crawler/variables.tf index 5eb08ae..dc736c4 100644 --- a/modules/glue-crawler/variables.tf +++ b/modules/glue-crawler/variables.tf @@ -105,7 +105,7 @@ variable "catalog_target" { variable "delta_target" { type = list(object({ connection_name = string - create_native_delta_table = bool + create_native_delta_table = optional(bool) delta_tables = list(string) write_manifest = bool })) From 1e7b85ff8c590bf64a100b49fa34de4fe030bb19 Mon Sep 17 00:00:00 2001 From: pkapoor-blackline <167803037+pkapoor-blackline@users.noreply.github.com> Date: Wed, 6 Aug 2025 17:43:00 -0400 Subject: [PATCH 3/3] Default optional create_native_delta_table to false --- modules/glue-crawler/variables.tf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/glue-crawler/variables.tf b/modules/glue-crawler/variables.tf index dc736c4..702d76a 100644 --- a/modules/glue-crawler/variables.tf +++ b/modules/glue-crawler/variables.tf @@ -105,7 +105,7 @@ variable "catalog_target" { variable "delta_target" { type = list(object({ connection_name = string - create_native_delta_table = optional(bool) + create_native_delta_table = optional(bool, false) delta_tables = list(string) write_manifest = bool }))