Use artifacts (#8)

* build artifacts

* lint

* Deploy artifacts to s3 bucket

* add region

* test improve-errors

* pin to a release

* Fix bundler

Author: osterman

.gitignore

@@ -12,4 +12,6 @@
 **/package-lock.json
 
 .build-harness
-build-harness
+build-harness
+
+*.zip

.travis.yml

@@ -5,6 +5,10 @@ addons:
       - make
       - curl
 
+env:
+  global:
+    - TERRAFORM_MODULE_NAME="$(basename $TRAVIS_REPO_SLUG)"
+
 install:
   - make init
 
@@ -13,4 +17,20 @@ script:
   - make terraform/get-plugins
   - make terraform/get-modules
   - make terraform/lint
-  - make terraform/validate
+  - make terraform/validate
+  - make build
+
+deploy:
+  # Deploy artifacts to S3
+  - provider: s3
+    region: "us-west-2"
+    access_key_id: $AWS_ACCESS_KEY_ID
+    secret_access_key: $AWS_SECRET_ACCESS_KEY
+    bucket: artifacts.prod.cloudposse.org
+    skip_cleanup: true
+    upload-dir: $TERRAFORM_MODULE_NAME/$TRAVIS_COMMIT
+    local-dir: artifacts
+    on:
+      all_branches: true
+
+

Makefile

@@ -7,5 +7,4 @@ export README_DEPS ?= docs/targets.md docs/terraform.md
 lint:
 	$(SELF) terraform/install terraform/get-modules terraform/get-plugins terraform/lint terraform/validate
 
-include Makefile.helpers
-include Makefile.ses
+include Makefile.ses

Makefile.helpers

@@ -1,13 +1,19 @@
-NPM ?= docker run -it -v $(pwd)/lambda/:/code -w /code --entrypoint=npm  node:8.10-alpine
+NPM ?= docker run -it -v $(shell pwd)/lambda/:/code -w /code --entrypoint=npm node:8.10-alpine
+
+# Ensures that a variable is defined
+define assert-set
+  @[ -n "$($1)" ] || (echo "$(1) not defined in $(@)"; exit 1)
+endef
 
 ## Build lambda package
 build:
 	$(NPM) update
 	sudo chmod -R 777 lambda
-	cd lambda && zip -r ../lambda.zip * && cd ../
+	mkdir -p artifacts
+	cd lambda && zip -r ../artifacts/lambda.zip *
 
 ## Verify $EMAIL used as gateway for forwarding
-verify_gateway_email:
+verify-gateway-email:
 	$(call assert-set,REGION)
 	$(call assert-set,EMAIL)
 	aws --region=$(REGION) ses verify-email-identity --email-address $(EMAIL)

Makefile.ses

@@ -66,12 +66,19 @@ resource "aws_iam_role_policy_attachment" "lambda" {
   policy_arn = "${aws_iam_policy.lambda.arn}"
 }
 
+module "artifact" {
+  source      = "git::https://github.com/cloudposse/terraform-external-module-artifact.git?ref=tags/0.1.1"
+  filename    = "lambda.zip"
+  module_name = "terraform-aws-ses-lambda-forwarder"
+  module_path = "${path.module}"
+}
+
 resource "aws_lambda_function" "default" {
-  filename         = "${join("/", list(path.module, "lambda.zip"))}"
+  filename         = "${module.artifact.file}"
   function_name    = "${module.label.id}"
   role             = "${aws_iam_role.lambda.arn}"
   handler          = "index.handler"
-  source_code_hash = "${base64sha256(file(join("/", list(path.module, "lambda.zip"))))}"
+  source_code_hash = "${module.artifact.base64sha256}"
   runtime          = "nodejs8.10"
 
   environment {