Revert 0.19.0 (#56)

## what
* Reverts the updates from #53 as they were no good. 

## why
* Using the flag to not write the back config file causes terraform to believe the file should be destroyed since it was no longer tracked as a resource. That approach just generally won't work. 

## references
* Reverts #53

Author: Gowiem

README.md

@@ -217,7 +217,6 @@ Available targets:
 | additional\_tag\_map | Additional tags for appending to each tag map | `map(string)` | `{}` | no |
 | arn\_format | ARN format to be used. May be changed to support deployment in GovCloud/China regions. | `string` | `"arn:aws"` | no |
 | attributes | Additional attributes (e.g. `state`) | `list(string)` | <pre>[<br>  "state"<br>]</pre> | no |
-| backend\_config\_file\_overwrite\_enabled | If false, the backend config file will not be overwritten if it exists. | `bool` | `true` | no |
 | billing\_mode | DynamoDB billing mode | `string` | `"PROVISIONED"` | no |
 | block\_public\_acls | Whether Amazon S3 should block public ACLs for this bucket | `bool` | `true` | no |
 | block\_public\_policy | Whether Amazon S3 should block public bucket policies for this bucket | `bool` | `true` | no |

docs/terraform.md

@@ -24,7 +24,6 @@
 | additional\_tag\_map | Additional tags for appending to each tag map | `map(string)` | `{}` | no |
 | arn\_format | ARN format to be used. May be changed to support deployment in GovCloud/China regions. | `string` | `"arn:aws"` | no |
 | attributes | Additional attributes (e.g. `state`) | `list(string)` | <pre>[<br>  "state"<br>]</pre> | no |
-| backend\_config\_file\_overwrite\_enabled | If false, the backend config file will not be overwritten if it exists. | `bool` | `true` | no |
 | billing\_mode | DynamoDB billing mode | `string` | `"PROVISIONED"` | no |
 | block\_public\_acls | Whether Amazon S3 should block public ACLs for this bucket | `bool` | `true` | no |
 | block\_public\_policy | Whether Amazon S3 should block public bucket policies for this bucket | `bool` | `true` | no |

main.tf

@@ -14,10 +14,6 @@ locals {
 
   terraform_backend_config_template_file = var.terraform_backend_config_template_file != "" ? var.terraform_backend_config_template_file : "${path.module}/templates/terraform.tf.tpl"
 
-  terraform_backend_config_file_exists = fileexists(local.terraform_backend_config_file)
-
-  overwrite_backend_config_file = (! local.terraform_backend_config_file_exists || var.backend_config_file_overwrite_enabled) && var.terraform_backend_config_file_path != ""
-
   bucket_name = var.s3_bucket_name != "" ? var.s3_bucket_name : module.s3_bucket_label.id
 }
 
@@ -250,11 +246,8 @@ data "template_file" "terraform_backend_config" {
   }
 }
 
-# We only write the backend config file if:
-# 1. The file doesn't exist and the module was given `terraform_backend_config_file_path`
-# 2. The file does exist, `backend_config_file_overwrite_enabled` is `true`, and the module was given `terraform_backend_config_file_path`
 resource "local_file" "terraform_backend_config" {
-  count    = local.overwrite_backend_config_file ? 1 : 0
+  count    = var.terraform_backend_config_file_path != "" ? 1 : 0
   content  = data.template_file.terraform_backend_config.rendered
   filename = local.terraform_backend_config_file
 }

variables.tf

@@ -221,12 +221,6 @@ variable "terraform_state_file" {
   description = "The path to the state file inside the bucket"
 }
 
-variable "backend_config_file_overwrite_enabled" {
-  type        = bool
-  default     = true
-  description = "If false, the backend config file will not be overwritten if it exists."
-}
-
 variable "s3_bucket_name" {
   type        = string
   default     = ""