Skip to content

AWS provider 6 support (aws_eip)#79

Merged
oycyc merged 2 commits intocloudposse:mainfrom
cardlay:main
Sep 1, 2025
Merged

AWS provider 6 support (aws_eip)#79
oycyc merged 2 commits intocloudposse:mainfrom
cardlay:main

Conversation

@mmh
Copy link
Contributor

@mmh mmh commented Aug 27, 2025

what

This PR makes it possible to use the module with the latest version of the AWS provider (version 6)

why

aws_eip no longer supports a vpc argument. It needs to be changed to domain

Causes this error when running terraform

│ Error: Unsupported argument
│ 
│   on .terraform/modules/sftp/main.tf line 105, in resource "aws_eip" "sftp":
│  105:   vpc = local.is_vpc
│ 
│ An argument named "vpc" is not expected here.

references

closes #78

@mmh mmh requested review from a team as code owners August 27, 2025 09:53
@mmh mmh requested review from RoseSecurity and jamengual August 27, 2025 09:53
@mergify mergify bot added the triage Needs triage label Aug 27, 2025
oycyc
oycyc previously approved these changes Aug 28, 2025
Copy link

@oycyc oycyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. Seeing this all over the place in multiple modules since the v6 release

@mergify mergify bot removed the triage Needs triage label Aug 28, 2025
@oycyc
Copy link

oycyc commented Aug 28, 2025

/terratest

@oycyc
Copy link

oycyc commented Aug 28, 2025

Can you also bump all the usage of cloudposse/dynamic-subnets/aws (e.g. in the /examples) to use the latest version to fix tests as well! Thanks.

@oycyc oycyc self-assigned this Aug 28, 2025
@mergify mergify bot added the triage Needs triage label Aug 29, 2025
@mmh
Copy link
Contributor Author

mmh commented Sep 1, 2025

@oycyc I have bumped all the cloudposse modules

@oycyc
Copy link

oycyc commented Sep 1, 2025

/terratest

Copy link

@oycyc oycyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@oycyc oycyc merged commit 31bfb4b into cloudposse:main Sep 1, 2025
28 checks passed
@mergify mergify bot removed the triage Needs triage label Sep 1, 2025
@github-actions
Copy link

github-actions bot commented Sep 1, 2025

These changes were released in v2.3.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error when using AWS provider version 6

2 participants