fix: Fallback to cached plugin in case docker plugin check fails (#571)

erezrokah · web-flow · commit 1032497544e7 · 2025-11-18T15:12:39.000Z
#### Summary

In case our API is down we should still try to use a cached version of the plugin. At the moment it won't work since `validateDockerPlugin` calls our API 

---
diff --git a/managedplugin/plugin.go b/managedplugin/plugin.go
@@ -223,7 +223,8 @@ func (c *Client) downloadPlugin(ctx context.Context, typ PluginType) (AssetSourc
 		}
 		isDocker, err := validateDockerPlugin(ctx, c.logger, hubClient, ops)
 		if err != nil {
-			return AssetSourceUnknown, err
+			c.logger.Error().Err(err).Msg("failed to validate docker plugin, falling back to download from hub or using cached plugin")
+			return DownloadPluginFromHub(ctx, c.logger, hubClient, ops, dops)
 		}
 		if isDocker {
 			path := fmt.Sprintf(c.cqDockerHost+"/%s/%s-%s:%s", ops.PluginTeam, ops.PluginKind, ops.PluginName, ops.PluginVersion)

Original file line number	Diff line number	Diff line change
`@@ -223,7 +223,8 @@ func (c *Client) downloadPlugin(ctx context.Context, typ PluginType) (AssetSourc`
`223`	`223`	`}`
`224`	`224`	`isDocker, err := validateDockerPlugin(ctx, c.logger, hubClient, ops)`
`225`	`225`	`if err != nil {`
`226`		`- return AssetSourceUnknown, err`
	`226`	`+ c.logger.Error().Err(err).Msg("failed to validate docker plugin, falling back to download from hub or using cached plugin")`
	`227`	`+ return DownloadPluginFromHub(ctx, c.logger, hubClient, ops, dops)`
`227`	`228`	`}`
`228`	`229`	`if isDocker {`
`229`	`230`	`path := fmt.Sprintf(c.cqDockerHost+"/%s/%s-%s:%s", ops.PluginTeam, ops.PluginKind, ops.PluginName, ops.PluginVersion)`