fix: Remove date in favor of timestamp, handle interval, pass underlying value to arrow (#62)

Author: erezrokah

src/scalar/date.ts

@@ -1,10 +1,9 @@
-import { DataType, Precision } from '@apache-arrow/esnext-esm';
+import { DataType, Precision, TimeUnit } from '@apache-arrow/esnext-esm';
 
 import { JSONType } from '../types/json.js';
 import { UUIDType } from '../types/uuid.js';
 
 import { Bool } from './bool.js';
-import { Date } from './date.js';
 import { Float32 } from './float32.js';
 import { Float64 } from './float64.js';
 import { Int16 } from './int16.js';
@@ -90,7 +89,13 @@ export const newScalar = (dataType: DataType): Scalar<unknown> => {
   }
 
   if (DataType.isDate(dataType)) {
-    return new Date(dataType.unit);
+    // TODO: Add Date support
+    return new Timestamp(TimeUnit.SECOND);
+  }
+
+  if (DataType.isInterval(dataType)) {
+    // TODO: Add Interval support
+    return new JSONScalar();
   }
 
   if (dataType instanceof UUIDType) {

src/scalar/scalar.ts

@@ -3,7 +3,6 @@ import { tableToIPC, Table as ArrowTable, RecordBatch, vectorFromArray } from '@
 import { ResourceError } from '../errors/errors.js';
 import type { Scalar, Vector } from '../scalar/scalar.js';
 import { newScalar } from '../scalar/scalar.js';
-import { isExtensionType } from '../types/extensions.js';
 
 import { cqIDColumn } from './meta.js';
 import type { Table } from './table.js';
@@ -64,11 +63,7 @@ export const encodeResource = (resource: Resource): Uint8Array => {
   let batch = new RecordBatch(schema, undefined);
   for (let index = 0; index < table.columns.length; index++) {
     const column = table.columns[index];
-    // For extension types, we need to get the underlying value
-    const data = isExtensionType(column.type)
-      ? resource.getColumnData(column.name).value
-      : resource.getColumnData(column.name);
-
+    const data = resource.getColumnData(column.name).value;
     const vector = vectorFromArray([data], column.type);
     batch = batch.setChildAt(index, vector);
   }