Skip to content

Commit 245c7e7

Browse files
committed
more tests
1 parent 94c85b9 commit 245c7e7

File tree

2 files changed

+13
-5
lines changed

2 files changed

+13
-5
lines changed

cloudquery/sdk/internal/servers/plugin_v3/plugin.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33

44
from cloudquery.plugin_v3 import plugin_pb2, plugin_pb2_grpc
55
from cloudquery.sdk.message import SyncInsertMessage, SyncMigrateTableMessage
6-
from cloudquery.sdk.plugin.plugin import Plugin, SyncOptions
6+
from cloudquery.sdk.plugin.plugin import Plugin, SyncOptions, TableOptions
77
from cloudquery.sdk.schema import tables_to_arrow_schemas
88

99

@@ -23,7 +23,7 @@ def Init(self, request: plugin_pb2.Init.Request, context):
2323
return plugin_pb2.Init.Response()
2424

2525
def GetTables(self, request: plugin_pb2.GetTables.Request, context):
26-
tables = self._plugin.get_tables(request.tables, request.skip_tables)
26+
tables = self._plugin.get_tables(TableOptions(tables=request.tables, skip_tables=request.skip_tables))
2727
schema = tables_to_arrow_schemas(tables)
2828
tablesBytes = []
2929
for s in schema:

tests/serve/plugin.py

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,11 @@
66
from cloudquery.sdk import serve
77
from cloudquery.sdk import plugin
88
from cloudquery.plugin_v3 import plugin_pb2_grpc, plugin_pb2
9+
from cloudquery.sdk.internal.memdb import MemDB
910

1011

1112
def test_plugin_serve():
12-
p = plugin.Plugin("test", "v1.0.0")
13+
p = MemDB()
1314
cmd = serve.PluginCommand(p)
1415
port = random.randint(5000, 50000)
1516
pool = futures.ThreadPoolExecutor(max_workers=1)
@@ -19,10 +20,17 @@ def test_plugin_serve():
1920
with grpc.insecure_channel(f'localhost:{port}') as channel:
2021
stub = plugin_pb2_grpc.PluginStub(channel)
2122
response = stub.GetName(plugin_pb2.GetName.Request())
22-
assert response.name == "test"
23+
assert response.name == "memdb"
2324

2425
response = stub.GetVersion(plugin_pb2.GetVersion.Request())
25-
assert response.version == "v1.0.0"
26+
assert response.version == "development"
27+
28+
response = stub.Init(plugin_pb2.Init.Request(spec=b""))
29+
assert response is not None
30+
31+
response = stub.GetTables(plugin_pb2.GetTables.Request())
32+
print(response.tables)
33+
assert response.tables is not None
2634
finally:
2735
cmd.stop()
2836
pool.shutdown()

0 commit comments

Comments
 (0)