Skip to content

Commit 286269f

Browse files
committed
Make sure Transform finishes.
1 parent 2d90985 commit 286269f

File tree

1 file changed

+2
-8
lines changed

1 file changed

+2
-8
lines changed

internal/servers/plugin/v3/plugin.go

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -480,16 +480,10 @@ func (s *Server) Transform(stream pb.Plugin_TransformServer) error {
480480
return err
481481
case <-gctx.Done():
482482
close(recvRecords)
483-
if err := eg.Wait(); err != nil {
484-
return status.Errorf(codes.Canceled, "plugin returned error: %v", err)
485-
}
486-
return status.Errorf(codes.Internal, "transform failed for unknown reason")
483+
return gctx.Err()
487484
case <-ctx.Done():
488485
close(recvRecords)
489-
if err := eg.Wait(); err != nil {
490-
return status.Errorf(codes.Internal, "context done: %v and failed to wait for plugin: %v", ctx.Err(), err)
491-
}
492-
return status.Errorf(codes.Canceled, "context done: %v", ctx.Err())
486+
return ctx.Err()
493487
}
494488
}
495489
})

0 commit comments

Comments
 (0)