chore(tests): Ensure interface contract between types.XArray.ValueStr & types.XBuilder.AppendValueFromString (#849)

Follow-up to apache/arrow#35457

BEGIN_COMMIT_OVERRIDE
chore(tests): Ensure interface contract between `types.XArray.ValueStr` & `types.XBuilder.AppendValueFromString` (#849)

feat(arrow): Add `types.XBuilder.NewXArray` helpers
END_COMMIT_OVERRIDE

Author: candiduslynx

types/extensions_test.go

@@ -0,0 +1,102 @@
+package types
+
+import (
+	"testing"
+
+	"github.com/apache/arrow/go/v12/arrow"
+	"github.com/apache/arrow/go/v12/arrow/array"
+	"github.com/apache/arrow/go/v12/arrow/memory"
+	"github.com/google/uuid"
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
+)
+
+func TestValueStrRoundTrip(t *testing.T) {
+	mem := memory.NewCheckedAllocator(memory.NewGoAllocator())
+	defer mem.AssertSize(t, 0)
+
+	cases := []struct {
+		arr     arrow.Array
+		builder array.Builder
+	}{
+		{
+			arr: func() arrow.Array {
+				b := NewInetBuilder(array.NewExtensionBuilder(mem, NewInetType()))
+				defer b.Release()
+
+				b.AppendNull()
+				b.Append(mustParseInet("192.168.0.0/24"))
+				b.AppendNull()
+				b.Append(mustParseInet("192.168.0.0/25"))
+				b.AppendNull()
+
+				return b.NewInetArray()
+			}(),
+			builder: NewInetBuilder(array.NewExtensionBuilder(mem, NewInetType())),
+		},
+		{
+			arr: func() arrow.Array {
+				b := NewJSONBuilder(array.NewExtensionBuilder(mem, NewJSONType()))
+				defer b.Release()
+
+				b.AppendNull()
+				b.Append(map[string]any{"a": 1, "b": 2})
+				b.AppendNull()
+				b.Append([]any{1, 2, 3})
+				b.AppendNull()
+				b.Append(map[string]any{"MyKey": "A\u0026B"})
+				b.AppendNull()
+
+				return b.NewJSONArray()
+			}(),
+			builder: NewJSONBuilder(array.NewExtensionBuilder(mem, NewJSONType())),
+		},
+		{
+			arr: func() arrow.Array {
+				b := NewMacBuilder(array.NewExtensionBuilder(mem, NewMacType()))
+				defer b.Release()
+
+				b.AppendNull()
+				b.Append(mustParseMac("00:00:00:00:00:01"))
+				b.AppendNull()
+				b.Append(mustParseMac("00:00:00:00:00:02"))
+				b.AppendNull()
+
+				return b.NewMacArray()
+			}(),
+			builder: NewMacBuilder(array.NewExtensionBuilder(mem, NewMacType())),
+		},
+		{
+			arr: func() arrow.Array {
+				b := NewUUIDBuilder(array.NewExtensionBuilder(mem, NewUUIDType()))
+				defer b.Release()
+
+				b.AppendNull()
+				b.Append(uuid.NameSpaceURL)
+				b.AppendNull()
+				b.Append(uuid.NameSpaceDNS)
+				b.AppendNull()
+
+				return b.NewUUIDArray()
+			}(),
+			builder: NewUUIDBuilder(array.NewExtensionBuilder(mem, NewUUIDType())),
+		},
+	}
+
+	for _, tc := range cases {
+		t.Run(tc.arr.DataType().(arrow.ExtensionType).ExtensionName(), func(t *testing.T) {
+			defer tc.arr.Release()
+			defer tc.builder.Release()
+			t.Helper()
+
+			for i := 0; i < tc.arr.Len(); i++ {
+				assert.NoError(t, tc.builder.AppendValueFromString(tc.arr.ValueStr(i)))
+			}
+
+			arr := tc.builder.NewArray()
+			defer arr.Release()
+
+			require.True(t, array.Equal(tc.arr, arr))
+		})
+	}
+}

types/inet.go

@@ -117,6 +117,10 @@ func (b *InetBuilder) UnmarshalJSON(data []byte) error {
 	return b.Unmarshal(dec)
 }
 
+func (b *InetBuilder) NewInetArray() *InetArray {
+	return b.NewExtensionArray().(*InetArray)
+}
+
 // InetArray is a simple array which is a FixedSizeBinary(16)
 type InetArray struct {
 	array.ExtensionArrayBase

types/json.go

@@ -110,6 +110,10 @@ func (b *JSONBuilder) UnmarshalJSON(data []byte) error {
 	return b.Unmarshal(dec)
 }
 
+func (b *JSONBuilder) NewJSONArray() *JSONArray {
+	return b.NewExtensionArray().(*JSONArray)
+}
+
 // JSONArray is a simple array which is a Binary
 type JSONArray struct {
 	array.ExtensionArrayBase

types/json_test.go

@@ -172,7 +172,7 @@ func TestJSONArray_GetOneForMarshal(t *testing.T) {
 	}
 }
 
-func TestJSONArray_ValueStr(t *testing.T) {
+func TestJSONArray_ValueStrParse(t *testing.T) {
 	cases := []struct {
 		name string
 		data string

types/mac.go

@@ -111,6 +111,10 @@ func (b *MacBuilder) UnmarshalJSON(data []byte) error {
 	return b.Unmarshal(dec)
 }
 
+func (b *MacBuilder) NewMacArray() *MacArray {
+	return b.NewExtensionArray().(*MacArray)
+}
+
 // MacArray is a simple array which is a wrapper around a BinaryArray
 type MacArray struct {
 	array.ExtensionArrayBase

types/uuid.go

@@ -113,6 +113,10 @@ func (b *UUIDBuilder) UnmarshalJSON(data []byte) error {
 	return b.Unmarshal(dec)
 }
 
+func (b *UUIDBuilder) NewUUIDArray() *UUIDArray {
+	return b.NewExtensionArray().(*UUIDArray)
+}
+
 // UUIDArray is a simple array which is a FixedSizeBinary(16)
 type UUIDArray struct {
 	array.ExtensionArrayBase