fix: Make static linking conditional only for Linux (#1310)

maaarcelino · web-flow · commit 35fa449c8877 · 2023-10-18T08:49:10.000Z
This applies the new static linking feature only for Linux platforms
diff --git a/serve/package.go b/serve/package.go
@@ -110,7 +110,7 @@ func (s *PluginServe) build(pluginDirectory, goos, goarch, distPath, pluginVersi
 		return nil, err
 	}
 	ldFlags := fmt.Sprintf("-s -w -X %s/plugin.Version=%s", importPath, pluginVersion)
-	if s.plugin.IsStaticLinkingEnabled() {
+	if s.plugin.IsStaticLinkingEnabled() && strings.EqualFold(goos, plugin.GoOSLinux) {
 		ldFlags += " -linkmode external -extldflags=-static"
 	}
 	args := []string{"build", "-o", pluginPath}

Original file line number	Diff line number	Diff line change
`@@ -110,7 +110,7 @@ func (s *PluginServe) build(pluginDirectory, goos, goarch, distPath, pluginVersi`
`110`	`110`	`return nil, err`
`111`	`111`	`}`
`112`	`112`	`ldFlags := fmt.Sprintf("-s -w -X %s/plugin.Version=%s", importPath, pluginVersion)`
`113`		`- if s.plugin.IsStaticLinkingEnabled() {`
	`113`	`+ if s.plugin.IsStaticLinkingEnabled() && strings.EqualFold(goos, plugin.GoOSLinux) {`
`114`	`114`	`ldFlags += " -linkmode external -extldflags=-static"`
`115`	`115`	`}`
`116`	`116`	`args := []string{"build", "-o", pluginPath}`