fix: Fix nil pointer dereference when remaining rows not set (#1339)

hermanschaaf · web-flow · commit 36a9d3534c26 · 2023-10-31T15:04:12.000Z
If remaining rows is not set, it indicates an infinite number of remaining rows (ie. the plugin is free)
diff --git a/premium/usage.go b/premium/usage.go
@@ -227,7 +227,8 @@ func (u *BatchUpdater) HasQuota(ctx context.Context) (bool, error) {
 	if usage.StatusCode() != http.StatusOK {
 		return false, fmt.Errorf("failed to get usage: %s", usage.Status())
 	}
-	return *usage.JSON200.RemainingRows > 0, nil
+	hasQuota := usage.JSON200.RemainingRows == nil || *usage.JSON200.RemainingRows > 0
+	return hasQuota, nil
 }
 
 func (u *BatchUpdater) Close() error {

Original file line number	Diff line number	Diff line change
`@@ -227,7 +227,8 @@ func (u *BatchUpdater) HasQuota(ctx context.Context) (bool, error) {`
`227`	`227`	`if usage.StatusCode() != http.StatusOK {`
`228`	`228`	`return false, fmt.Errorf("failed to get usage: %s", usage.Status())`
`229`	`229`	`}`
`230`		`- return *usage.JSON200.RemainingRows > 0, nil`
	`230`	`+ hasQuota := usage.JSON200.RemainingRows == nil \|\| *usage.JSON200.RemainingRows > 0`
	`231`	`+ return hasQuota, nil`
`231`	`232`	`}`
`232`	`233`
`233`	`234`	`func (u *BatchUpdater) Close() error {`