fix: Pass correct value for plugin version (#2156)

erezrokah · web-flow · commit 37b41572165f · 2025-05-19T12:09:19.000Z
#### Summary This should fix embedding plugin version, I broke this a while back #1974 ---
diff --git a/serve/package.go b/serve/package.go
@@ -129,7 +129,7 @@ func (s *PluginServe) build(pluginDirectory string, target plugin.BuildTarget, d
 	if target.IncludeSymbols {
 		stripSymbols = ""
 	}
-	ldFlags := fmt.Sprintf("%[1]s -w -X %[2]s/plugin.Version=%[3]s -X %[2]s/resources/plugin.Version=%[2]s", stripSymbols, importPath, pluginVersion)
+	ldFlags := fmt.Sprintf("%[1]s -w -X %[2]s/plugin.Version=%[3]s -X %[2]s/resources/plugin.Version=%[3]s", stripSymbols, importPath, pluginVersion)
 	args := []string{"build", "-o", pluginPath}
 	args = append(args, "-buildmode=exe")
 	args = append(args, "-ldflags", ldFlags)

Original file line number	Diff line number	Diff line change
`@@ -129,7 +129,7 @@ func (s *PluginServe) build(pluginDirectory string, target plugin.BuildTarget, d`
`129`	`129`	`if target.IncludeSymbols {`
`130`	`130`	`stripSymbols = ""`
`131`	`131`	`}`
`132`		`- ldFlags := fmt.Sprintf("%[1]s -w -X %[2]s/plugin.Version=%[3]s -X %[2]s/resources/plugin.Version=%[2]s", stripSymbols, importPath, pluginVersion)`
	`132`	`+ ldFlags := fmt.Sprintf("%[1]s -w -X %[2]s/plugin.Version=%[3]s -X %[2]s/resources/plugin.Version=%[3]s", stripSymbols, importPath, pluginVersion)`
`133`	`133`	`args := []string{"build", "-o", pluginPath}`
`134`	`134`	`args = append(args, "-buildmode=exe")`
`135`	`135`	`args = append(args, "-ldflags", ldFlags)`