fix: Add missing comma when generating relations (#78)

Author: erezrokah

codegen/.snapshots/TestGenerateTemplate-should_add_comma_between_relations

@@ -0,0 +1,13 @@
+{
+		Name:         "with relations",
+		Columns: []schema.Column{
+
+		},
+
+		Relations: []*schema.Table{
+relation1,
+relation2,
+
+		},
+
+}

codegen/golang_test.go

@@ -6,9 +6,11 @@ import (
 	"testing"
 	"time"
 
+	"github.com/bradleyjkemp/cupaloy"
 	"github.com/cloudquery/plugin-sdk/schema"
 	"github.com/google/go-cmp/cmp"
 	"github.com/google/go-cmp/cmp/cmpopts"
+	"github.com/stretchr/testify/require"
 )
 
 type testStruct struct {
@@ -98,3 +100,33 @@ func TestTableFromGoStruct(t *testing.T) {
 // func TestReadComments(t *testing.T) {
 // 	readComments("github.com/google/go-cmp/cmp")
 // }
+
+func TestGenerateTemplate(t *testing.T) {
+	type args struct {
+		table *TableDefinition
+	}
+
+	tests := []struct {
+		name string
+		args args
+	}{
+		{
+			name: "should add comma between relations",
+			args: args{
+				table: &TableDefinition{
+					Name:      "with relations",
+					Relations: []string{"relation1", "relation2"},
+				},
+			},
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			buf := bytes.NewBufferString("")
+			err := tt.args.table.GenerateTemplate(buf)
+			require.NoError(t, err)
+			cupaloy.SnapshotT(t, buf.Bytes())
+		})
+	}
+}

codegen/templates/table.go.tpl

@@ -20,7 +20,8 @@
 		},
 {{with .Relations}}
 		Relations: []*schema.Table{
-{{range .}}{{.}}{{end}},
+{{range .}}{{.}},
+{{end}}
 		},
 {{end}}
 }

go.mod

@@ -27,6 +27,7 @@ require (
 )
 
 require (
+	github.com/bradleyjkemp/cupaloy v2.3.0+incompatible // indirect
 	github.com/davecgh/go-spew v1.1.1 // indirect
 	github.com/gogo/protobuf v1.3.2 // indirect
 	github.com/golang/protobuf v1.5.2 // indirect

go.sum

@@ -2,6 +2,8 @@ cloud.google.com/go v0.26.0/go.mod h1:aQUYkXzVsufM+DwF1aE+0xfcU+56JwCaLick0ClmMT
 cloud.google.com/go v0.34.0/go.mod h1:aQUYkXzVsufM+DwF1aE+0xfcU+56JwCaLick0ClmMTw=
 github.com/BurntSushi/toml v0.3.1/go.mod h1:xHWCNGjB5oqiDr8zfno3MHue2Ht5sIBksp03qcyfWMU=
 github.com/antihax/optional v1.0.0/go.mod h1:uupD/76wgC+ih3iEmQUL+0Ugr19nfwCT1kdvxnR2qWY=
+github.com/bradleyjkemp/cupaloy v2.3.0+incompatible h1:UafIjBvWQmS9i/xRg+CamMrnLTKNzo+bdmT/oH34c2Y=
+github.com/bradleyjkemp/cupaloy v2.3.0+incompatible/go.mod h1:Au1Xw1sgaJ5iSFktEhYsS0dbQiS1B0/XMXl+42y9Ilk=
 github.com/census-instrumentation/opencensus-proto v0.2.1/go.mod h1:f6KPmirojxKA12rnyqOA5BBL4O983OfeGPqjHWSTneU=
 github.com/cespare/xxhash/v2 v2.1.1/go.mod h1:VGX0DQ3Q6kWi7AoAeZDth3/j3BFtOZR5XLFGgcrjCOs=
 github.com/client9/misspell v0.3.4/go.mod h1:qj6jICC3Q7zFZvVWo7KLAzC3yx5G7kyvSDkc90ppPyw=