chore: Test scheduler strategy JSON schema (#1276)

Author: candiduslynx

scheduler/strategy.go

@@ -57,7 +57,6 @@ func (s *Strategy) Validate() error {
 	return fmt.Errorf("unknown scheduler strategy: %d", s)
 }
 
-// JSONSchema uses value receiver because of https://github.com/invopop/jsonschema/issues/102
 func (Strategy) JSONSchema() *jsonschema.Schema {
 	enum := make([]any, len(AllStrategyNames))
 	for i, s := range AllStrategyNames {

scheduler/strategy.json

@@ -6,17 +6,69 @@ import (
 	"reflect"
 	"testing"
 
+	"github.com/cloudquery/plugin-sdk/v4/plugin"
 	"github.com/cloudquery/plugin-sdk/v4/scheduler"
 	"github.com/invopop/jsonschema"
 	"github.com/stretchr/testify/require"
 )
 
-//go:embed strategy.json
-var jsonSchema string
-
 func TestStrategy_JSONSchema(t *testing.T) {
 	sc := (&jsonschema.Reflector{RequiredFromJSONSchemaTags: true}).ReflectFromType(reflect.TypeOf(scheduler.StrategyDFS))
-	data, err := json.MarshalIndent(sc, "", "  ")
+	schema, err := json.MarshalIndent(sc, "", "  ")
+	require.NoError(t, err)
+
+	validator, err := plugin.JSONSchemaValidator(string(schema))
 	require.NoError(t, err)
-	require.JSONEq(t, string(data)+"\n", jsonSchema)
+
+	type testCase struct {
+		Name string
+		Spec string
+		Err  bool
+	}
+
+	for _, tc := range []testCase{
+		{
+			Name: "dfs scheduler",
+			Spec: `"dfs"`,
+		},
+		{
+			Name: "round-robin scheduler",
+			Spec: `"round-robin"`,
+		},
+		{
+			Name: "shuffle scheduler",
+			Spec: `"shuffle"`,
+		},
+		{
+			Name: "empty scheduler",
+			Err:  true,
+			Spec: `""`,
+		},
+		{
+			Name: "bad scheduler",
+			Err:  true,
+			Spec: `"bad"`,
+		},
+		{
+			Name: "bad scheduler type",
+			Err:  true,
+			Spec: `123`,
+		},
+		{
+			Name: "null scheduler type",
+			Err:  true,
+			Spec: `null`,
+		},
+	} {
+		t.Run(tc.Name, func(t *testing.T) {
+			var val any
+			err := json.Unmarshal([]byte(tc.Spec), &val)
+			require.NoError(t, err)
+			if tc.Err {
+				require.Error(t, validator.Validate(val))
+			} else {
+				require.NoError(t, validator.Validate(val))
+			}
+		})
+	}
 }