fix(tests): Parallel plugin testing, remove old faker (#292)

Something like cloudquery/cloudquery#2788 but in the sdk.

Author: disq

go.mod

@@ -4,7 +4,6 @@ go 1.19
 
 require (
 	github.com/bradleyjkemp/cupaloy/v2 v2.8.0
-	github.com/cloudquery/faker/v3 v3.7.7
 	github.com/getsentry/sentry-go v0.13.0
 	github.com/ghodss/yaml v1.0.0
 	github.com/gofrs/uuid v4.3.0+incompatible
@@ -14,6 +13,7 @@ require (
 	github.com/grpc-ecosystem/go-grpc-middleware/v2 v2.0.0-rc.2
 	github.com/modern-go/reflect2 v1.0.2
 	github.com/rs/zerolog v1.28.0
+	github.com/schollz/progressbar/v3 v3.11.0
 	github.com/spf13/cast v1.5.0
 	github.com/spf13/cobra v1.5.0
 	github.com/stretchr/testify v1.8.0
@@ -38,7 +38,6 @@ require (
 	github.com/mitchellh/colorstring v0.0.0-20190213212951-d06e56a500db // indirect
 	github.com/pmezard/go-difflib v1.0.0 // indirect
 	github.com/rivo/uniseg v0.4.2 // indirect
-	github.com/schollz/progressbar/v3 v3.11.0 // indirect
 	github.com/spf13/pflag v1.0.5 // indirect
 	github.com/xeipuuv/gojsonpointer v0.0.0-20190905194746-02993c407bfb // indirect
 	github.com/xeipuuv/gojsonreference v0.0.0-20180127040603-bd5ef7bd5415 // indirect

go.sum

@@ -3,8 +3,6 @@ github.com/BurntSushi/toml v0.3.1/go.mod h1:xHWCNGjB5oqiDr8zfno3MHue2Ht5sIBksp03
 github.com/bradleyjkemp/cupaloy/v2 v2.8.0 h1:any4BmKE+jGIaMpnU8YgH/I2LPiLBufr6oMMlVBbn9M=
 github.com/bradleyjkemp/cupaloy/v2 v2.8.0/go.mod h1:bm7JXdkRd4BHJk9HpwqAI8BoAY1lps46Enkdqw6aRX0=
 github.com/client9/misspell v0.3.4/go.mod h1:qj6jICC3Q7zFZvVWo7KLAzC3yx5G7kyvSDkc90ppPyw=
-github.com/cloudquery/faker/v3 v3.7.7 h1:vODOmAXGhxAacVrUOjr4Jti2lFhXgkPjG6/L3C2REgQ=
-github.com/cloudquery/faker/v3 v3.7.7/go.mod h1:1b8WVG9Gh0T2hVo1a8dWeXfu0AhqSB6J/mmJaesqOeo=
 github.com/coreos/go-systemd v0.0.0-20190321100706-95778dfbb74e/go.mod h1:F5haX7vjVVG0kc13fIWeqUViNPyEJxv/OmvnBo0Yme4=
 github.com/coreos/go-systemd/v22 v22.3.3-0.20220203105225-a9a7ef127534/go.mod h1:Y58oyj3AT4RCenI/lSvhwexgC+NSVTIJ3seZv2GcEnc=
 github.com/cpuguy83/go-md2man/v2 v2.0.2/go.mod h1:tgQtvFlXSQOSOSIRvRPT7W67SCa46tRHOmNcaadrF8o=
@@ -146,8 +144,6 @@ golang.org/x/sys v0.0.0-20210630005230-0f9fa26af87c/go.mod h1:oPkhp1MJrh7nUepCBc
 golang.org/x/sys v0.0.0-20210927094055-39ccf1dd6fa6/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
 golang.org/x/sys v0.0.0-20220811171246-fbc7d0a398ab/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
 golang.org/x/sys v0.0.0-20220829200755-d48e67d00261/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
-golang.org/x/sys v0.0.0-20220919091848-fb04ddd9f9c8 h1:h+EGohizhe9XlX18rfpa8k8RAc5XyaeamM+0VHRd4lc=
-golang.org/x/sys v0.0.0-20220919091848-fb04ddd9f9c8/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
 golang.org/x/sys v0.0.0-20220928140112-f11e5e49a4ec h1:BkDtF2Ih9xZ7le9ndzTA7KJow28VbQW3odyk/8drmuI=
 golang.org/x/sys v0.0.0-20220928140112-f11e5e49a4ec/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
 golang.org/x/term v0.0.0-20220722155259-a9ba230a4035/go.mod h1:jbD1KX2456YbFQfuXm/mYQcufACuNUgVhRMnK/tPxf8=

plugins/source_testing.go

@@ -5,7 +5,6 @@ import (
 	"encoding/json"
 	"testing"
 
-	"github.com/cloudquery/faker/v3"
 	"github.com/cloudquery/plugin-sdk/schema"
 	"github.com/cloudquery/plugin-sdk/specs"
 	"github.com/rs/zerolog"
@@ -21,14 +20,19 @@ type ResourceTestCase struct {
 	SkipIgnoreInTest bool
 }
 
-func init() {
-	_ = faker.SetRandomMapAndSliceMinSize(1)
-	_ = faker.SetRandomMapAndSliceMaxSize(1)
-}
-
-func TestSourcePluginSync(t *testing.T, plugin *SourcePlugin, logger zerolog.Logger, spec specs.Source) {
+func TestSourcePluginSync(t *testing.T, plugin *SourcePlugin, logger zerolog.Logger, spec specs.Source, opts ...TestSourcePluginOption) {
 	t.Helper()
 
+	o := &testSourcePluginOptions{
+		parallel: true,
+	}
+	for _, opt := range opts {
+		opt(o)
+	}
+	if o.parallel {
+		t.Parallel()
+	}
+
 	resourcesChannel := make(chan *schema.Resource)
 	var fetchErr error
 
@@ -46,6 +50,18 @@ func TestSourcePluginSync(t *testing.T, plugin *SourcePlugin, logger zerolog.Log
 	validateTables(t, plugin.Tables(), syncedResources)
 }
 
+type TestSourcePluginOption func(*testSourcePluginOptions)
+
+func WithTestSourcePluginNoParallel() TestSourcePluginOption {
+	return func(f *testSourcePluginOptions) {
+		f.parallel = false
+	}
+}
+
+type testSourcePluginOptions struct {
+	parallel bool
+}
+
 func getTableResources(t *testing.T, table *schema.Table, resources []*schema.Resource) []*schema.Resource {
 	t.Helper()
 

schema/column_test.go

@@ -9,7 +9,6 @@ import (
 	"testing"
 	"time"
 
-	"github.com/cloudquery/faker/v3"
 	"github.com/google/uuid"
 	"github.com/stretchr/testify/assert"
 	"github.com/thoas/go-funk"
@@ -109,26 +108,30 @@ var validateFixtures = []validateFixture{
 }
 
 func GenerateMac() net.HardwareAddr {
-	mac, _ := net.ParseMAC(faker.MacAddress())
-	return mac
+	hw, err := net.ParseMAC(`00:00:00:00:fe:80:00:00:00:00:00:00:02:00:5e:10:00:00:00:01`)
+	if err != nil {
+		panic(err)
+	}
+	return hw
 }
 func GenerateMacPtr() *net.HardwareAddr {
-	mac, _ := net.ParseMAC(faker.MacAddress())
-	return &mac
+	r := GenerateMac()
+	return &r
 }
 
 func GenerateIPv4Ptr() *net.IP {
-	ip := net.ParseIP(faker.IPv4())
-	return &ip
+	r := net.ParseIP("127.0.0.1")
+	return &r
 }
 
 func GenerateIPv6Ptr() *net.IP {
-	ip := net.ParseIP(faker.IPv6())
-	return &ip
+	r := net.ParseIP("2001:db8::68")
+	return &r
 }
 
 func GenerateCIDR() *net.IPNet {
-	_, mask, _ := net.ParseCIDR(fmt.Sprintf("%s/%d", faker.IPv4(), rand.Int31n(16)+16))
+	ip := GenerateIPv4Ptr()
+	_, mask, _ := net.ParseCIDR(fmt.Sprintf("%s/%d", ip.String(), rand.Int31n(16)+16))
 	return mask
 }