fix!: Enable var names lint rule and fix issues (#88)

We have a bunch of useful lint rules disable since it would have taken a lot of work to fix all the issues.
With the new SDK we can start fixing the issues gradually

---

Author: erezrokah

.golangci.yml

@@ -47,8 +47,6 @@ linters-settings:
         disabled: true
       - name: unhandled-error
         disabled: true
-      - name: var-naming
-        disabled: true
       - name: deep-exit
         disabled: true
       - name: nested-structs

faker/faker.go

@@ -8,8 +8,7 @@ import (
 )
 
 type faker struct {
-	max_depth int
-	// logger    zerolog.Logger
+	maxDepth int
 }
 
 type Option func(*faker)
@@ -19,8 +18,8 @@ func (f faker) getFakedValue(a interface{}) (reflect.Value, error) {
 	if t == nil {
 		return reflect.Value{}, fmt.Errorf("interface{} not allowed")
 	}
-	f.max_depth--
-	if f.max_depth < 0 {
+	f.maxDepth--
+	if f.maxDepth < 0 {
 		return reflect.Value{}, fmt.Errorf("max_depth reached")
 	}
 	k := t.Kind()
@@ -145,7 +144,7 @@ func (f faker) getFakedValue(a interface{}) (reflect.Value, error) {
 
 func WithMaxDepth(depth int) Option {
 	return func(f *faker) {
-		f.max_depth = depth
+		f.maxDepth = depth
 	}
 }
 
@@ -160,7 +159,7 @@ func FakeObject(obj interface{}, opts ...Option) error {
 		return fmt.Errorf("object is nil %s", reflectType.Elem().String())
 	}
 	f := &faker{
-		max_depth: 12,
+		maxDepth: 12,
 	}
 	for _, o := range opts {
 		o(f)

plugins/source.go

@@ -50,11 +50,11 @@ func WithSourceLogger(logger zerolog.Logger) SourceOption {
 // Add internal columns
 func addInternalColumns(tables []*schema.Table) {
 	for _, table := range tables {
-		cqId := schema.CqIdColumn
+		cqID := schema.CqIDColumn
 		if len(table.PrimaryKeys()) == 0 {
-			cqId.CreationOptions.PrimaryKey = true
+			cqID.CreationOptions.PrimaryKey = true
 		}
-		table.Columns = append(table.Columns, cqId, schema.CqFetchTime)
+		table.Columns = append(table.Columns, cqID, schema.CqFetchTime)
 		addInternalColumns(table.Relations)
 	}
 }

schema/filters.go

@@ -1,11 +1,11 @@
 package schema
 
-// DeleteParentIdFilter is mostly used for table relations to delete table data based on parent's cq_id
-func DeleteParentIdFilter(id string) func(meta ClientMeta, parent *Resource) []interface{} {
+// DeleteParentIDFilter is mostly used for table relations to delete table data based on parent's cq_id
+func DeleteParentIDFilter(id string) func(meta ClientMeta, parent *Resource) []interface{} {
 	return func(meta ClientMeta, parent *Resource) []interface{} {
 		if parent == nil {
 			return nil
 		}
-		return []interface{}{id, parent.Id()}
+		return []interface{}{id, parent.ID()}
 	}
 }

schema/meta.go

@@ -12,15 +12,15 @@ type ClientMeta interface {
 
 type Meta struct {
 	LastUpdate time.Time `json:"last_updated"`
-	FetchId    string    `json:"fetch_id,omitempty"`
+	FetchID    string    `json:"fetch_id,omitempty"`
 }
 
-const FetchIdMetaKey = "cq_fetch_id"
+const FetchIDMetaKey = "cq_fetch_id"
 
-var CqIdColumn = Column{Name: "_cq_id", Type: TypeUUID, Description: "Internal CQ ID of the row", Resolver: CQUUIDResolver()}
+var CqIDColumn = Column{Name: "_cq_id", Type: TypeUUID, Description: "Internal CQ ID of the row", Resolver: CQUUIDResolver()}
 var CqFetchTime = Column{Name: "_cq_fetch_time", Type: TypeTimestamp, Description: "Internal CQ row of when fetch was started (this will be the same for all rows in a single fetch)"}
 
 var CqColumns = []Column{
-	CqIdColumn,
+	CqIDColumn,
 	CqFetchTime,
 }

schema/resolvers.go

@@ -26,10 +26,10 @@ func CQUUIDResolver() ColumnResolver {
 	}
 }
 
-// ParentIdResolver resolves the cq_id from the parent
+// ParentIDResolver resolves the cq_id from the parent
 // if you want to reference the parent's primary keys use ParentResourceFieldResolver as required.
-func ParentIdResolver(_ context.Context, _ ClientMeta, r *Resource, c Column) error {
-	return r.Set(c.Name, r.Parent.Id())
+func ParentIDResolver(_ context.Context, _ ClientMeta, r *Resource, c Column) error {
+	return r.Set(c.Name, r.Parent.ID())
 }
 
 // ParentResourceFieldResolver resolves a field from the parent's resource, the value is expected to be set

schema/resource.go

@@ -77,11 +77,11 @@ func (r *Resource) SetItem(item interface{}) {
 	r.Item = item
 }
 
-func (r *Resource) Id() uuid.UUID {
-	if r.Data[CqIdColumn.Name] == nil {
+func (r *Resource) ID() uuid.UUID {
+	if r.Data[CqIDColumn.Name] == nil {
 		return uuid.UUID{}
 	}
-	return r.Data[CqIdColumn.Name].(uuid.UUID)
+	return r.Data[CqIDColumn.Name].(uuid.UUID)
 }
 
 func (r *Resource) Columns() []string {
@@ -91,7 +91,7 @@ func (r *Resource) Columns() []string {
 func (rr Resources) GetIds() []uuid.UUID {
 	rids := make([]uuid.UUID, len(rr))
 	for i, r := range rr {
-		rids[i] = r.Id()
+		rids[i] = r.ID()
 	}
 	return rids
 }

specs/spec.go

@@ -78,7 +78,7 @@ func (s *Spec) UnmarshalJSON(data []byte) error {
 	return json.Unmarshal(b, s.Spec)
 }
 
-func UnmarshalJsonStrict(b []byte, out interface{}) error {
+func UnmarshalJSONStrict(b []byte, out interface{}) error {
 	dec := json.NewDecoder(bytes.NewReader(b))
 	dec.DisallowUnknownFields()
 	dec.UseNumber()