Update package.go

Author: bbernays

serve/package.go

@@ -117,7 +117,7 @@ func (s *PluginServe) writeTablesJSON(ctx context.Context, dir string) error {
 	return os.WriteFile(outputPath, buffer.Bytes(), 0644)
 }
 
-func (s *PluginServe) build(pluginDirectory string, target plugin.BuildTarget, distPath, pluginVersion, buildTags string) (*TargetBuild, error) {
+func (s *PluginServe) build(pluginDirectory string, target plugin.BuildTarget, distPath, pluginVersion string) (*TargetBuild, error) {
 	pluginFileName := fmt.Sprintf("plugin-%s-%s-%s-%s", s.plugin.Name(), pluginVersion, target.OS, target.Arch)
 	pluginPath := path.Join(distPath, pluginFileName)
 	importPath, err := s.getModuleName(pluginDirectory)
@@ -132,9 +132,9 @@ func (s *PluginServe) build(pluginDirectory string, target plugin.BuildTarget, d
 	args := []string{"build", "-o", pluginPath}
 	args = append(args, "-buildmode=exe")
 	args = append(args, "-ldflags", ldFlags)
-	// This disables gRPC tracing, which introduces a dependency that blocks dead code elimination\
-	// https://github.com/grpc/grpc-go/blob/030938e543b4a721cd426d15611d50ecf097dcf3/trace_notrace.go#L23-L25
-	args = append(args, "-tags", buildTags)
+	// // This disables gRPC tracing, which introduces a dependency that blocks dead code elimination\
+	// // https://github.com/grpc/grpc-go/blob/030938e543b4a721cd426d15611d50ecf097dcf3/trace_notrace.go#L23-L25
+	// args = append(args, "-tags", buildTags)
 	cmd := exec.Command("go", args...)
 	cmd.Dir = pluginDirectory
 	cmd.Stdout = os.Stdout
@@ -404,10 +404,6 @@ func (s *PluginServe) newCmdPluginPackage() *cobra.Command {
 				message = string(messageBytes)
 			}
 			message = normalizeMessage(message)
-			buildTags := "grpcnotrace"
-			if cmd.Flag("build-tags").Changed {
-				buildTags = cmd.Flag("build-tags").Value.String()
-			}
 
 			if err := os.MkdirAll(distPath, 0755); err != nil {
 				return err
@@ -441,7 +437,7 @@ func (s *PluginServe) newCmdPluginPackage() *cobra.Command {
 			targets := []TargetBuild{}
 			for _, target := range s.plugin.Targets() {
 				fmt.Println("Building for OS: " + target.OS + ", ARCH: " + target.Arch)
-				targetBuild, err := s.build(pluginDirectory, target, distPath, pluginVersion, buildTags)
+				targetBuild, err := s.build(pluginDirectory, target, distPath, pluginVersion)
 				if err != nil {
 					return fmt.Errorf("failed to build plugin for %s/%s: %w", target.OS, target.Arch, err)
 				}