allow inserting a custom function for replacing time.Now in hashing tests

Author: blesniewski

configtype/time.go

@@ -15,9 +15,10 @@ import (
 // when a time type is required. We wrap the time.Time type so that
 // the spec can be extended in the future to support other types of times
 type Time struct {
-	input    string
-	time     time.Time
-	duration *timeDuration
+	input       string
+	time        time.Time
+	duration    *timeDuration
+	hashNowFunc func() time.Time
 }
 
 func ParseTime(s string) (Time, error) {
@@ -131,10 +132,18 @@ func (t Time) String() string {
 }
 
 func (t Time) Hash() (uint64, error) {
-	at := t.AsTime(time.Date(2000, 1, 1, 0, 0, 0, 0, time.UTC))
+	nowFunc := t.hashNowFunc
+	if nowFunc == nil {
+		nowFunc = time.Now
+	}
+	at := t.AsTime(nowFunc())
 	return uint64(at.UnixNano()), nil
 }
 
+func (t *Time) SetHashNowFunc(f func() time.Time) {
+	t.hashNowFunc = f
+}
+
 type timeDuration struct {
 	input string
 

configtype/time_test.go

@@ -154,40 +154,54 @@ func TestTime_JSONSchema(t *testing.T) {
 }
 
 func TestTime_Hashing(t *testing.T) {
+	hnf := func() time.Time { return time.Date(2000, 1, 1, 0, 0, 0, 0, time.UTC) }
 	cases := []struct {
-		a     any
-		b     any
-		equal bool
+		a           configtype.Time
+		b           configtype.Time
+		hashNowFunc func() time.Time
+		equal       bool
 	}{
 		{
-			a:     func() any { ct, _ := configtype.ParseTime("10m"); return ct }(),
-			b:     func() any { ct, _ := configtype.ParseTime("10m"); return ct }(),
-			equal: true,
+			a:           func() configtype.Time { ct, _ := configtype.ParseTime("10m"); return ct }(),
+			b:           func() configtype.Time { ct, _ := configtype.ParseTime("10m"); return ct }(),
+			hashNowFunc: hnf,
+			equal:       true,
 		},
 		{
-			a:     func() any { ct, _ := configtype.ParseTime("10m"); return ct }(),
-			b:     func() any { ct, _ := configtype.ParseTime("1m"); return ct }(),
+			a:     func() configtype.Time { ct, _ := configtype.ParseTime("10m"); return ct }(),
+			b:     func() configtype.Time { ct, _ := configtype.ParseTime("10m"); return ct }(),
 			equal: false,
 		},
 		{
-			a:     func() any { ct, _ := configtype.ParseTime("2021-09-01T00:00:00Z"); return ct }(),
-			b:     func() any { ct, _ := configtype.ParseTime("2012-01-02T01:02:03Z"); return ct }(),
+			a:     func() configtype.Time { ct, _ := configtype.ParseTime("10m"); return ct }(),
+			b:     func() configtype.Time { ct, _ := configtype.ParseTime("1m"); return ct }(),
 			equal: false,
 		},
 		{
-			a:     func() any { ct, _ := configtype.ParseTime("-50m30s"); return ct }(),
-			b:     func() any { ct, _ := configtype.ParseTime("50 minutes 30 seconds ago"); return ct }(),
-			equal: true,
+			a:           func() configtype.Time { ct, _ := configtype.ParseTime("2021-09-01T00:00:00Z"); return ct }(),
+			b:           func() configtype.Time { ct, _ := configtype.ParseTime("2012-01-02T01:02:03Z"); return ct }(),
+			hashNowFunc: hnf,
+			equal:       false,
 		},
 		{
-			a:     func() any { ct, _ := configtype.ParseTime("50m30s"); return ct }(),
-			b:     func() any { ct, _ := configtype.ParseTime("50 minutes 30 seconds from now"); return ct }(),
-			equal: true,
+			a:           func() configtype.Time { ct, _ := configtype.ParseTime("-50m30s"); return ct }(),
+			b:           func() configtype.Time { ct, _ := configtype.ParseTime("50 minutes 30 seconds ago"); return ct }(),
+			hashNowFunc: hnf,
+			equal:       true,
+		},
+		{
+			a:           func() configtype.Time { ct, _ := configtype.ParseTime("50m30s"); return ct }(),
+			b:           func() configtype.Time { ct, _ := configtype.ParseTime("50 minutes 30 seconds from now"); return ct }(),
+			hashNowFunc: hnf,
+			equal:       true,
 		},
 	}
 	for _, tc := range cases {
+		tc.a.SetHashNowFunc(tc.hashNowFunc)
 		hashA, err := hashstructure.Hash(tc.a, hashstructure.FormatV2, nil)
 		require.NoError(t, err)
+		time.Sleep(1 * time.Second)
+		tc.b.SetHashNowFunc(tc.hashNowFunc)
 		hashB, err := hashstructure.Hash(tc.b, hashstructure.FormatV2, nil)
 		require.NoError(t, err)