fix(configtype): Add Equal() method to Duration (#1059)

`cmp.Diff` doesn't like it otherwise.

Author: disq

configtype/duration.go

@@ -39,3 +39,7 @@ func (d *Duration) MarshalJSON() ([]byte, error) {
 func (d *Duration) Duration() time.Duration {
 	return d.duration
 }
+
+func (d Duration) Equal(other Duration) bool {
+	return d.duration == other.duration
+}

configtype/duration_test.go

@@ -1,9 +1,12 @@
-package configtype
+package configtype_test
 
 import (
 	"encoding/json"
 	"testing"
 	"time"
+
+	"github.com/cloudquery/plugin-sdk/v4/configtype"
+	"github.com/google/go-cmp/cmp"
 )
 
 func TestDuration(t *testing.T) {
@@ -16,7 +19,7 @@ func TestDuration(t *testing.T) {
 		{"-50m30s", -50*time.Minute - 30*time.Second},
 	}
 	for _, tc := range cases {
-		var d Duration
+		var d configtype.Duration
 		err := json.Unmarshal([]byte(`"`+tc.give+`"`), &d)
 		if err != nil {
 			t.Fatalf("error calling Unmarshal(%q): %v", tc.give, err)
@@ -26,3 +29,26 @@ func TestDuration(t *testing.T) {
 		}
 	}
 }
+
+func TestComparability(t *testing.T) {
+	cases := []struct {
+		give    configtype.Duration
+		compare configtype.Duration
+		equal   bool
+	}{
+		{configtype.NewDuration(0), configtype.NewDuration(0), true},
+		{configtype.NewDuration(0), configtype.NewDuration(1), false},
+	}
+	for _, tc := range cases {
+		if (tc.give == tc.compare) != tc.equal {
+			t.Errorf("comparing %v and %v should be %v", tc.give, tc.compare, tc.equal)
+		}
+
+		diff := cmp.Diff(tc.give, tc.compare)
+		if tc.equal && diff != "" {
+			t.Errorf("comparing %v and %v should be equal, but diff is %s", tc.give, tc.compare, diff)
+		} else if !tc.equal && diff == "" {
+			t.Errorf("comparing %v and %v should not be equal, but diff is empty", tc.give, tc.compare)
+		}
+	}
+}