fix: Relax plugin tables and columns validation (#1203)

Follow up to #1108. This PR relaxes the validation to check only for duplicates.
Some databases allow uppercase table tables and the validation in the SDK seemed to be PostgreSQL oriented.
At some point we might want to have destination specific validation/normalization.

Related to https://discord.com/channels/872925471417962546/873606591335759872/1148643989348679770

---

Author: erezrokah

plugin/validate.go

@@ -13,18 +13,10 @@ func validateTables(tables schema.Tables) error {
 		return fmt.Errorf("found duplicate tables in plugin: %w", err)
 	}
 
-	if err := tables.ValidateTableNames(); err != nil {
-		return fmt.Errorf("found table with invalid name in plugin: %w", err)
-	}
-
 	if err := tables.ValidateDuplicateColumns(); err != nil {
 		return fmt.Errorf("found duplicate columns in plugin: %w", err)
 	}
 
-	if err := tables.ValidateColumnNames(); err != nil {
-		return fmt.Errorf("found column with invalid name in plugin: %w", err)
-	}
-
 	return nil
 }
 

schema/table.go

@@ -90,7 +90,6 @@ type Table struct {
 }
 
 var (
-	reValidTableName  = regexp.MustCompile(`^[a-z_][a-z\d_]*$`)
 	reValidColumnName = regexp.MustCompile(`^[a-z_][a-z\d_]*$`)
 )
 
@@ -359,30 +358,6 @@ func (tt Tables) ValidateDuplicateTables() error {
 	return nil
 }
 
-func (tt Tables) ValidateTableNames() error {
-	for _, t := range tt {
-		if err := t.ValidateName(); err != nil {
-			return err
-		}
-		if err := t.Relations.ValidateTableNames(); err != nil {
-			return err
-		}
-	}
-	return nil
-}
-
-func (tt Tables) ValidateColumnNames() error {
-	for _, t := range tt {
-		if err := t.ValidateColumnNames(); err != nil {
-			return err
-		}
-		if err := t.Relations.ValidateColumnNames(); err != nil {
-			return err
-		}
-	}
-	return nil
-}
-
 // this will filter the tree in-place
 func (t *Table) filterDfs(parentMatched bool, include, exclude func(*Table) bool, skipDependentTables bool) *Table {
 	if exclude(t) {
@@ -407,14 +382,6 @@ func (t *Table) filterDfs(parentMatched bool, include, exclude func(*Table) bool
 	return nil
 }
 
-func (t *Table) ValidateName() error {
-	ok := reValidTableName.MatchString(t.Name)
-	if !ok {
-		return fmt.Errorf("table name %q is not valid: table names must contain only lower-case letters, numbers and underscores, and must start with a lower-case letter or underscore", t.Name)
-	}
-	return ValidateTable(t)
-}
-
 func (t *Table) PrimaryKeysIndexes() []int {
 	var primaryKeys []int
 	for i, c := range t.Columns {
@@ -500,15 +467,6 @@ func (t *Table) ValidateDuplicateColumns() error {
 	return nil
 }
 
-func (t *Table) ValidateColumnNames() error {
-	for _, c := range t.Columns {
-		if !ValidColumnName(c.Name) {
-			return fmt.Errorf("column name %q on table %q is not valid: column names must contain only lower-case letters, numbers and underscores, and must start with a lower-case letter or underscore", c.Name, t.Name)
-		}
-	}
-	return nil
-}
-
 func (t *Table) Column(name string) *Column {
 	for _, c := range t.Columns {
 		if c.Name == name {

schema/validators.go

@@ -1,61 +1,9 @@
 package schema
 
 import (
-	"errors"
-	"fmt"
-
 	"github.com/apache/arrow/go/v14/arrow"
 )
 
-type TableValidator interface {
-	Validate(t *Table) error
-}
-
-type LengthTableValidator struct{}
-
-const (
-	maxTableName  = 63 // maximum allowed identifier length is 63 bytes https://www.postgresql.org/docs/13/limits.html
-	maxColumnName = 63
-)
-
-var defaultValidators = []TableValidator{
-	LengthTableValidator{},
-}
-
-func ValidateTable(t *Table) error {
-	for _, validator := range defaultValidators {
-		return validator.Validate(t)
-	}
-	return nil
-}
-
-func validateTableAttributesNameLength(t *Table) error {
-	// validate table name
-	if len(t.Name) > maxTableName {
-		return errors.New("table name has exceeded max length")
-	}
-
-	// validate table columns
-	for _, col := range t.Columns.Names() {
-		if len(col) > maxColumnName {
-			return fmt.Errorf("column name %s has exceeded max length", col)
-		}
-	}
-
-	// validate table relations
-	for _, rel := range t.Relations {
-		err := validateTableAttributesNameLength(rel)
-		if err != nil {
-			return err
-		}
-	}
-	return nil
-}
-
-func (LengthTableValidator) Validate(t *Table) error {
-	return validateTableAttributesNameLength(t)
-}
-
 func FindEmptyColumns(table *Table, records []arrow.Record) []string {
 	columnsWithValues := make([]bool, len(table.Columns))
 	emptyColumns := make([]string, 0)