style: Lint

erezrokah · erezrokah · commit 625a40f8e1ed · 2025-03-05T11:51:36.000Z
diff --git a/.golangci.yml b/.golangci.yml
@@ -86,3 +86,6 @@ linters:
     - unconvert
     - unparam
     - unused
+issues:
+  max-issues-per-linter: 0
+  max-same-issues: 0
diff --git a/configtype/time.go b/configtype/time.go
@@ -2,6 +2,7 @@ package configtype
 
 import (
 	"encoding/json"
+	"errors"
 	"fmt"
 	"math"
 	"regexp"
@@ -212,13 +213,13 @@ func parseTimeDuration(s string) (timeDuration, error) {
 			inValue = false
 		case part == "ago":
 			if d.sign != 0 {
-				return timeDuration{}, fmt.Errorf("invalid duration format: more than one sign specifier")
+				return timeDuration{}, errors.New("invalid duration format: more than one sign specifier")
 			}
 
 			d.sign = -1
 		case part == "from":
 			if d.sign != 0 {
-				return timeDuration{}, fmt.Errorf("invalid duration format: more than one sign specifier")
+				return timeDuration{}, errors.New("invalid duration format: more than one sign specifier")
 			}
 
 			inSign = true
diff --git a/faker/faker.go b/faker/faker.go
@@ -2,6 +2,7 @@ package faker
 
 import (
 	"encoding/json"
+	"errors"
 	"fmt"
 	"math/rand"
 	"reflect"
@@ -15,7 +16,7 @@ type faker struct {
 	logger   zerolog.Logger
 }
 
-var errEFaceNotAllowed = fmt.Errorf("any not allowed")
+var errEFaceNotAllowed = errors.New("any not allowed")
 
 func (f faker) getFakedValue(a any) (reflect.Value, error) {
 	t := reflect.TypeOf(a)
@@ -24,7 +25,7 @@ func (f faker) getFakedValue(a any) (reflect.Value, error) {
 	}
 	f.maxDepth--
 	if f.maxDepth < 0 {
-		return reflect.Value{}, fmt.Errorf("max_depth reached")
+		return reflect.Value{}, errors.New("max_depth reached")
 	}
 	k := t.Kind()
 	switch k {
@@ -176,7 +177,7 @@ func FakeObject(obj any, opts ...Option) error {
 	reflectType := reflect.TypeOf(obj)
 
 	if reflectType.Kind() != reflect.Ptr {
-		return fmt.Errorf("object is not a pointer")
+		return errors.New("object is not a pointer")
 	}
 
 	if reflect.ValueOf(obj).IsNil() {
diff --git a/helpers/remoteoauth/token.go b/helpers/remoteoauth/token.go
@@ -114,7 +114,7 @@ func (t *cloudTokenSource) retrieveToken(ctx context.Context) (*oauth2.Token, er
 	}
 
 	if oauthResp == nil {
-		return nil, fmt.Errorf("missing oauth credentials in response")
+		return nil, errors.New("missing oauth credentials in response")
 	}
 
 	tok := &oauth2.Token{
diff --git a/internal/memdb/memdb.go b/internal/memdb/memdb.go
@@ -2,7 +2,7 @@ package memdb
 
 import (
 	"context"
-	"fmt"
+	"errors"
 	"sync"
 
 	"github.com/apache/arrow-go/v18/arrow"
@@ -108,7 +108,7 @@ func NewMemDBClient(ctx context.Context, l zerolog.Logger, spec []byte, options
 }
 
 func NewMemDBClientErrOnNew(context.Context, zerolog.Logger, []byte, plugin.NewClientOptions) (plugin.Client, error) {
-	return nil, fmt.Errorf("newTestDestinationMemDBClientErrOnNew")
+	return nil, errors.New("newTestDestinationMemDBClientErrOnNew")
 }
 
 func (c *client) overwrite(table *schema.Table, record arrow.Record) {
@@ -211,12 +211,12 @@ func (c *client) migrate(_ context.Context, table *schema.Table) {
 
 func (c *client) Write(ctx context.Context, msgs <-chan message.WriteMessage) error {
 	if c.errOnWrite {
-		return fmt.Errorf("errOnWrite")
+		return errors.New("errOnWrite")
 	}
 	if c.blockingWrite {
 		<-ctx.Done()
 		if c.errOnWrite {
-			return fmt.Errorf("errOnWrite")
+			return errors.New("errOnWrite")
 		}
 		return nil
 	}
@@ -235,7 +235,7 @@ func (c *client) Write(ctx context.Context, msgs <-chan message.WriteMessage) er
 			sc := msg.Record.Schema()
 			tableName, ok := sc.Metadata().GetValue(schema.MetadataTableName)
 			if !ok {
-				return fmt.Errorf("table name not found in schema metadata")
+				return errors.New("table name not found in schema metadata")
 			}
 			table := c.tables[tableName]
 			c.overwrite(table, msg.Record)
diff --git a/plugin/plugin.go b/plugin/plugin.go
@@ -2,6 +2,7 @@ package plugin
 
 import (
 	"context"
+	"errors"
 	"fmt"
 	"sync"
 
@@ -13,7 +14,7 @@ import (
 	"github.com/santhosh-tekuri/jsonschema/v6"
 )
 
-var ErrNotImplemented = fmt.Errorf("not implemented")
+var ErrNotImplemented = errors.New("not implemented")
 
 type NewClientOptions struct {
 	NoConnection bool
@@ -215,7 +216,7 @@ func (p *Plugin) SetLogger(logger zerolog.Logger) {
 
 func (p *Plugin) Tables(ctx context.Context, options TableOptions) (schema.Tables, error) {
 	if p.client == nil {
-		return nil, fmt.Errorf("plugin not initialized")
+		return nil, errors.New("plugin not initialized")
 	}
 	tables, err := p.client.Tables(ctx, options)
 	if err != nil {
@@ -227,7 +228,7 @@ func (p *Plugin) Tables(ctx context.Context, options TableOptions) (schema.Table
 // Init initializes the plugin with the given spec.
 func (p *Plugin) Init(ctx context.Context, spec []byte, options NewClientOptions) error {
 	if !p.mu.TryLock() {
-		return fmt.Errorf("plugin already in use")
+		return errors.New("plugin already in use")
 	}
 	defer p.mu.Unlock()
 	var err error
@@ -257,7 +258,7 @@ func (p *Plugin) Init(ctx context.Context, spec []byte, options NewClientOptions
 
 func (p *Plugin) Close(ctx context.Context) error {
 	if !p.mu.TryLock() {
-		return fmt.Errorf("plugin already in use")
+		return errors.New("plugin already in use")
 	}
 	defer p.mu.Unlock()
 	if p.client == nil {
diff --git a/plugin/plugin_destination.go b/plugin/plugin_destination.go
@@ -2,6 +2,7 @@ package plugin
 
 import (
 	"context"
+	"errors"
 	"fmt"
 
 	"github.com/apache/arrow-go/v18/arrow"
@@ -33,19 +34,19 @@ func (p *Plugin) WriteAll(ctx context.Context, resources []message.WriteMessage)
 
 func (p *Plugin) Write(ctx context.Context, res <-chan message.WriteMessage) error {
 	if p.client == nil {
-		return fmt.Errorf("plugin is not initialized. call Init first")
+		return errors.New("plugin is not initialized. call Init first")
 	}
 	return p.client.Write(ctx, res)
 }
 
 // Read is read data from the requested table to the given channel, returned in the same format as the table
 func (p *Plugin) Read(ctx context.Context, table *schema.Table, res chan<- arrow.Record) error {
 	if !p.mu.TryLock() {
-		return fmt.Errorf("plugin already in use")
+		return errors.New("plugin already in use")
 	}
 	defer p.mu.Unlock()
 	if p.client == nil {
-		return fmt.Errorf("plugin not initialized. call Init() first")
+		return errors.New("plugin not initialized. call Init() first")
 	}
 	if err := p.client.Read(ctx, table, res); err != nil {
 		return fmt.Errorf("failed to read: %w", err)
diff --git a/plugin/plugin_source.go b/plugin/plugin_source.go
@@ -2,6 +2,7 @@ package plugin
 
 import (
 	"context"
+	"errors"
 	"fmt"
 
 	"github.com/cloudquery/plugin-sdk/v4/glob"
@@ -88,11 +89,11 @@ func (p *Plugin) SyncAll(ctx context.Context, options SyncOptions) (message.Sync
 // Sync is syncing data from the requested tables in spec to the given channel
 func (p *Plugin) Sync(ctx context.Context, options SyncOptions, res chan<- message.SyncMessage) error {
 	if !p.mu.TryLock() {
-		return fmt.Errorf("plugin already in use")
+		return errors.New("plugin already in use")
 	}
 	defer p.mu.Unlock()
 	if p.client == nil {
-		return fmt.Errorf("plugin not initialized. call Init() first")
+		return errors.New("plugin not initialized. call Init() first")
 	}
 
 	if err := p.client.Sync(ctx, options, res); err != nil {
diff --git a/premium/usage.go b/premium/usage.go
@@ -334,15 +334,15 @@ func awsMarketplaceProductCode() string {
 
 func (u *BatchUpdater) Increase(rows uint32) error {
 	if u.usageIncreaseMethod == UsageIncreaseMethodBreakdown {
-		return fmt.Errorf("mixing usage increase methods is not allowed, use IncreaseForTable instead")
+		return errors.New("mixing usage increase methods is not allowed, use IncreaseForTable instead")
 	}
 
 	if rows <= 0 {
 		return fmt.Errorf("rows must be greater than zero got %d", rows)
 	}
 
 	if u.isClosed {
-		return fmt.Errorf("usage updater is closed")
+		return errors.New("usage updater is closed")
 	}
 
 	u.Lock()
@@ -364,15 +364,15 @@ func (u *BatchUpdater) Increase(rows uint32) error {
 
 func (u *BatchUpdater) IncreaseForTable(table string, rows uint32) error {
 	if u.usageIncreaseMethod == UsageIncreaseMethodTotal {
-		return fmt.Errorf("mixing usage increase methods is not allowed, use Increase instead")
+		return errors.New("mixing usage increase methods is not allowed, use Increase instead")
 	}
 
 	if rows <= 0 {
 		return fmt.Errorf("rows must be greater than zero got %d", rows)
 	}
 
 	if u.isClosed {
-		return fmt.Errorf("usage updater is closed")
+		return errors.New("usage updater is closed")
 	}
 
 	u.Lock()
@@ -696,7 +696,7 @@ func (u *BatchUpdater) getTeamNameByTokenType(tokenType auth.TokenType) (string,
 			return "", fmt.Errorf("failed to get team name from config: %w", err)
 		}
 		if teamName == "" {
-			return "", fmt.Errorf("team name not set. Hint: use `cloudquery switch <team>`")
+			return "", errors.New("team name not set. Hint: use `cloudquery switch <team>`")
 		}
 		return teamName, nil
 	case auth.APIKey:
@@ -716,7 +716,7 @@ func (u *BatchUpdater) getTeamNameByTokenType(tokenType auth.TokenType) (string,
 		if team == "" {
 			switch tokenType {
 			case auth.SyncRunAPIKey, auth.SyncTestConnectionAPIKey:
-				return "", fmt.Errorf("_CQ_TEAM_NAME environment variable not set")
+				return "", errors.New("_CQ_TEAM_NAME environment variable not set")
 			}
 			return "", fmt.Errorf("unsupported token type: %v", tokenType)
 		}
diff --git a/schema/table.go b/schema/table.go
@@ -3,6 +3,7 @@ package schema
 import (
 	"context"
 	"encoding/json"
+	"errors"
 	"fmt"
 	"regexp"
 	"slices"
@@ -177,7 +178,7 @@ func NewTableFromArrowSchema(sc *arrow.Schema) (*Table, error) {
 	tableMD := sc.Metadata()
 	name, found := tableMD.GetValue(MetadataTableName)
 	if !found {
-		return nil, fmt.Errorf("missing table name")
+		return nil, errors.New("missing table name")
 	}
 	description, _ := tableMD.GetValue(MetadataTableDescription)
 	constraintName, _ := tableMD.GetValue(MetadataConstraintName)
diff --git a/serve/package.go b/serve/package.go
@@ -215,7 +215,7 @@ func (*PluginServe) getModuleName(pluginDirectory string) (string, error) {
 	reMod := regexp.MustCompile(`module\s+(.+)\n`)
 	importPathMatches := reMod.FindStringSubmatch(string(goMod))
 	if len(importPathMatches) != 2 {
-		return "", fmt.Errorf("failed to parse import path from go.mod")
+		return "", errors.New("failed to parse import path from go.mod")
 	}
 	importPath := importPathMatches[1]
 	return strings.TrimSpace(importPath), nil
@@ -336,7 +336,7 @@ func (s *PluginServe) validatePluginExports(pluginPath string) error {
 		}
 	}
 	if !foundVersion {
-		return fmt.Errorf("could not find `Version` global variable in package")
+		return errors.New("could not find `Version` global variable in package")
 	}
 
 	return nil
@@ -389,7 +389,7 @@ func (s *PluginServe) newCmdPluginPackage() *cobra.Command {
 			}
 			message := ""
 			if !cmd.Flag("message").Changed {
-				return fmt.Errorf("message is required")
+				return errors.New("message is required")
 			}
 			message = cmd.Flag("message").Value.String()
 			if strings.HasPrefix(message, "@") {
@@ -407,13 +407,13 @@ func (s *PluginServe) newCmdPluginPackage() *cobra.Command {
 			}
 
 			if s.plugin.Name() == "" {
-				return fmt.Errorf("plugin name is required for packaging")
+				return errors.New("plugin name is required for packaging")
 			}
 			if s.plugin.Team() == "" {
-				return fmt.Errorf("plugin team is required (hint: use the plugin.WithTeam() option)")
+				return errors.New("plugin team is required (hint: use the plugin.WithTeam() option)")
 			}
 			if s.plugin.Kind() == "" {
-				return fmt.Errorf("plugin kind is required (hint: use the plugin.WithKind() option)")
+				return errors.New("plugin kind is required (hint: use the plugin.WithKind() option)")
 			}
 
 			if err := s.validatePluginExports(pluginDirectory); err != nil {
diff --git a/writers/batchwriter/batchwriter.go b/writers/batchwriter/batchwriter.go
@@ -2,7 +2,7 @@ package batchwriter
 
 import (
 	"context"
-	"fmt"
+	"errors"
 	"sync"
 	"time"
 
@@ -338,7 +338,7 @@ func (w *BatchWriter) startWorker(_ context.Context, msg *message.WriteInsert) e
 	tableName, ok := md.GetValue(schema.MetadataTableName)
 	if !ok {
 		w.workersLock.RUnlock()
-		return fmt.Errorf("table name not found in metadata")
+		return errors.New("table name not found in metadata")
 	}
 	wr, ok := w.workers[tableName]
 	w.workersLock.RUnlock()
diff --git a/writers/streamingbatchwriter/streamingbatchwriter.go b/writers/streamingbatchwriter/streamingbatchwriter.go
@@ -21,6 +21,7 @@ package streamingbatchwriter
 
 import (
 	"context"
+	"errors"
 	"fmt"
 	"sync"
 	"time"
@@ -211,7 +212,7 @@ func (w *StreamingBatchWriter) startWorker(ctx context.Context, errCh chan<- err
 		md := mi.Record.Schema().Metadata()
 		tableName, ok = md.GetValue(schema.MetadataTableName)
 		if !ok {
-			return fmt.Errorf("table name not found in metadata")
+			return errors.New("table name not found in metadata")
 		}
 	} else {
 		tableName = msg.GetTable().Name

Original file line number	Diff line number	Diff line change
`@@ -114,7 +114,7 @@ func (t cloudTokenSource) retrieveToken(ctx context.Context) (oauth2.Token, er`
`114`	`114`	`}`
`115`	`115`
`116`	`116`	`if oauthResp == nil {`
`117`		`- return nil, fmt.Errorf("missing oauth credentials in response")`
	`117`	`+ return nil, errors.New("missing oauth credentials in response")`
`118`	`118`	`}`
`119`	`119`
`120`	`120`	`tok := &oauth2.Token{`
Original file line number	Diff line number	Diff line change
`@@ -2,7 +2,7 @@ package memdb`
`2`	`2`
`3`	`3`	`import (`
`4`	`4`	`"context"`
`5`		`- "fmt"`
	`5`	`+ "errors"`
`6`	`6`	`"sync"`
`7`	`7`
`8`	`8`	`"github.com/apache/arrow-go/v18/arrow"`
`@@ -108,7 +108,7 @@ func NewMemDBClient(ctx context.Context, l zerolog.Logger, spec []byte, options`
`108`	`108`	`}`
`109`	`109`
`110`	`110`	`func NewMemDBClientErrOnNew(context.Context, zerolog.Logger, []byte, plugin.NewClientOptions) (plugin.Client, error) {`
`111`		`- return nil, fmt.Errorf("newTestDestinationMemDBClientErrOnNew")`
	`111`	`+ return nil, errors.New("newTestDestinationMemDBClientErrOnNew")`
`112`	`112`	`}`
`113`	`113`
`114`	`114`	`func (c client) overwrite(table schema.Table, record arrow.Record) {`
`@@ -211,12 +211,12 @@ func (c client) migrate(_ context.Context, table schema.Table) {`
`211`	`211`
`212`	`212`	`func (c *client) Write(ctx context.Context, msgs <-chan message.WriteMessage) error {`
`213`	`213`	`if c.errOnWrite {`
`214`		`- return fmt.Errorf("errOnWrite")`
	`214`	`+ return errors.New("errOnWrite")`
`215`	`215`	`}`
`216`	`216`	`if c.blockingWrite {`
`217`	`217`	`<-ctx.Done()`
`218`	`218`	`if c.errOnWrite {`
`219`		`- return fmt.Errorf("errOnWrite")`
	`219`	`+ return errors.New("errOnWrite")`
`220`	`220`	`}`
`221`	`221`	`return nil`
`222`	`222`	`}`
`@@ -235,7 +235,7 @@ func (c *client) Write(ctx context.Context, msgs <-chan message.WriteMessage) er`
`235`	`235`	`sc := msg.Record.Schema()`
`236`	`236`	`tableName, ok := sc.Metadata().GetValue(schema.MetadataTableName)`
`237`	`237`	`if !ok {`
`238`		`- return fmt.Errorf("table name not found in schema metadata")`
	`238`	`+ return errors.New("table name not found in schema metadata")`
`239`	`239`	`}`
`240`	`240`	`table := c.tables[tableName]`
`241`	`241`	`c.overwrite(table, msg.Record)`
Original file line number	Diff line number	Diff line change
`@@ -334,15 +334,15 @@ func awsMarketplaceProductCode() string {`
`334`	`334`
`335`	`335`	`func (u *BatchUpdater) Increase(rows uint32) error {`
`336`	`336`	`if u.usageIncreaseMethod == UsageIncreaseMethodBreakdown {`
`337`		`- return fmt.Errorf("mixing usage increase methods is not allowed, use IncreaseForTable instead")`
	`337`	`+ return errors.New("mixing usage increase methods is not allowed, use IncreaseForTable instead")`
`338`	`338`	`}`
`339`	`339`
`340`	`340`	`if rows <= 0 {`
`341`	`341`	`return fmt.Errorf("rows must be greater than zero got %d", rows)`
`342`	`342`	`}`
`343`	`343`
`344`	`344`	`if u.isClosed {`
`345`		`- return fmt.Errorf("usage updater is closed")`
	`345`	`+ return errors.New("usage updater is closed")`
`346`	`346`	`}`
`347`	`347`
`348`	`348`	`u.Lock()`
`@@ -364,15 +364,15 @@ func (u *BatchUpdater) Increase(rows uint32) error {`
`364`	`364`
`365`	`365`	`func (u *BatchUpdater) IncreaseForTable(table string, rows uint32) error {`
`366`	`366`	`if u.usageIncreaseMethod == UsageIncreaseMethodTotal {`
`367`		`- return fmt.Errorf("mixing usage increase methods is not allowed, use Increase instead")`
	`367`	`+ return errors.New("mixing usage increase methods is not allowed, use Increase instead")`
`368`	`368`	`}`
`369`	`369`
`370`	`370`	`if rows <= 0 {`
`371`	`371`	`return fmt.Errorf("rows must be greater than zero got %d", rows)`
`372`	`372`	`}`
`373`	`373`
`374`	`374`	`if u.isClosed {`
`375`		`- return fmt.Errorf("usage updater is closed")`
	`375`	`+ return errors.New("usage updater is closed")`
`376`	`376`	`}`
`377`	`377`
`378`	`378`	`u.Lock()`
`@@ -696,7 +696,7 @@ func (u *BatchUpdater) getTeamNameByTokenType(tokenType auth.TokenType) (string,`
`696`	`696`	`return "", fmt.Errorf("failed to get team name from config: %w", err)`
`697`	`697`	`}`
`698`	`698`	`if teamName == "" {`
`699`		- return "", fmt.Errorf("team name not set. Hint: use `cloudquery switch <team>`")
	`699`	+ return "", errors.New("team name not set. Hint: use `cloudquery switch <team>`")
`700`	`700`	`}`
`701`	`701`	`return teamName, nil`
`702`	`702`	`case auth.APIKey:`
`@@ -716,7 +716,7 @@ func (u *BatchUpdater) getTeamNameByTokenType(tokenType auth.TokenType) (string,`
`716`	`716`	`if team == "" {`
`717`	`717`	`switch tokenType {`
`718`	`718`	`case auth.SyncRunAPIKey, auth.SyncTestConnectionAPIKey:`
`719`		`- return "", fmt.Errorf("_CQ_TEAM_NAME environment variable not set")`
	`719`	`+ return "", errors.New("_CQ_TEAM_NAME environment variable not set")`
`720`	`720`	`}`
`721`	`721`	`return "", fmt.Errorf("unsupported token type: %v", tokenType)`
`722`	`722`	`}`