feat!: Depracate override columns (#86)

feat: Depracate override columns

Author: erezrokah

codegen/golang.go

@@ -69,12 +69,6 @@ func WithSkipFields(fields []string) TableOptions {
 	}
 }
 
-func WithOverrideColumns(columns []ColumnDefinition) TableOptions {
-	return func(t *TableDefinition) {
-		t.overrideColumns = columns
-	}
-}
-
 func WithExtraColumns(columns []ColumnDefinition) TableOptions {
 	return func(t *TableDefinition) {
 		t.extraColumns = columns
@@ -122,15 +116,7 @@ func NewTableFromStruct(name string, obj interface{}, opts ...TableOptions) (*Ta
 		comments = readStructComments(e.Type().PkgPath(), e.Type().Name())
 	}
 
-	for _, c := range t.extraColumns {
-		if t.overrideColumns != nil {
-			if col := t.overrideColumns.GetByName(c.Name); col != nil {
-				t.Columns = append(t.Columns, *col)
-				continue
-			}
-		}
-		t.Columns = append(t.Columns, c)
-	}
+	t.Columns = append(t.Columns, t.extraColumns...)
 
 	for i := 0; i < e.NumField(); i++ {
 		field := e.Type().Field(i)
@@ -144,13 +130,6 @@ func NewTableFromStruct(name string, obj interface{}, opts ...TableOptions) (*Ta
 			continue
 		}
 
-		if t.overrideColumns != nil {
-			if col := t.overrideColumns.GetByName(t.nameTransformer(field.Name)); col != nil {
-				t.Columns = append(t.Columns, *col)
-				continue
-			}
-		}
-
 		columnType, err := valueToSchemaType(field.Type)
 		if err != nil {
 			fmt.Printf("skipping field %s, got err: %v\n", field.Name, err)

codegen/table.go

@@ -22,7 +22,6 @@ type TableDefinition struct {
 	PreResourceResolver  string
 	nameTransformer      func(string) string
 	skipFields           []string
-	overrideColumns      ColumnDefinitions
 	extraColumns         ColumnDefinitions
 	descriptionsEnabled  bool
 }