fix: Release resource on SkipSecondAppend (#808)

hermanschaaf · web-flow · commit 6f19c2d69f33 · 2023-04-19T16:27:06.000Z
In this case `writeOne` is not called on the record, so we should release it ourselves.
diff --git a/plugins/destination/plugin_testing_write_append.go b/plugins/destination/plugin_testing_write_append.go
@@ -57,6 +57,8 @@ func (s *PluginTestSuite) destinationPluginTestWriteAppend(ctx context.Context,
 		if err := p.writeOne(ctx, specSource, secondSyncTime, record2); err != nil {
 			return fmt.Errorf("failed to write one second time: %w", err)
 		}
+	} else {
+		record2.Release()
 	}
 
 	resourcesRead, err := p.readAll(ctx, tables[0], sourceName)

Original file line number	Diff line number	Diff line change
`@@ -57,6 +57,8 @@ func (s *PluginTestSuite) destinationPluginTestWriteAppend(ctx context.Context,`
`57`	`57`	`if err := p.writeOne(ctx, specSource, secondSyncTime, record2); err != nil {`
`58`	`58`	`return fmt.Errorf("failed to write one second time: %w", err)`
`59`	`59`	`}`
	`60`	`+ } else {`
	`61`	`+ record2.Release()`
`60`	`62`	`}`
`61`	`63`
`62`	`64`	`resourcesRead, err := p.readAll(ctx, tables[0], sourceName)`