fix(scalar): Don't pass typed nils in list values (#1226)

Fixes issues like cloudquery/cloudquery-issues#595

Author: disq

scalar/list.go

@@ -93,7 +93,11 @@ func (s *List) Set(val any) error {
 		s.Value = make(Vector, length)
 		for i := 0; i < length; i++ {
 			s.Value[i] = NewScalar(s.Type.(*arrow.ListType).Elem())
-			if err := s.Value[i].Set(reflectedValue.Index(i).Interface()); err != nil {
+			iVal := reflectedValue.Index(i)
+			if isReflectValueNil(iVal) {
+				continue
+			}
+			if err := s.Value[i].Set(iVal.Interface()); err != nil {
 				return err
 			}
 		}
@@ -102,3 +106,16 @@ func (s *List) Set(val any) error {
 	s.Valid = true
 	return nil
 }
+
+func isReflectValueNil(v reflect.Value) bool {
+	switch v.Kind() {
+	case reflect.Pointer,
+		reflect.UnsafePointer,
+		reflect.Map,
+		reflect.Slice,
+		reflect.Interface:
+		return v.IsNil()
+	default:
+		return false
+	}
+}

scalar/list_test.go

@@ -1,12 +1,17 @@
 package scalar
 
 import (
+	"net"
 	"testing"
 
 	"github.com/apache/arrow/go/v14/arrow"
+	"github.com/cloudquery/plugin-sdk/v4/types"
 )
 
 func TestListSet(t *testing.T) {
+	ipOne := net.IP{192, 168, 1, 1}
+	ipNet := net.IPNet{IP: ipOne, Mask: net.IPMask{255, 255, 255, 255}}
+	typedNil := (*net.IP)(nil)
 	successfulTests := []struct {
 		source any
 		result List
@@ -23,6 +28,15 @@ func TestListSet(t *testing.T) {
 				&Int{Value: 1, Valid: true},
 				&Int{Value: 2, Valid: true},
 			}, Valid: true, Type: arrow.ListOf(arrow.PrimitiveTypes.Int64)}},
+		{source: []*net.IPNet{&ipNet, nil}, result: List{Value: []Scalar{
+			&Inet{Value: &ipNet, Valid: true},
+			&Inet{Valid: false},
+		}, Valid: true, Type: arrow.ListOf(types.ExtensionTypes.Inet)}},
+		{source: []*net.IP{&ipOne, typedNil, nil}, result: List{Value: []Scalar{
+			&Inet{Value: &ipNet, Valid: true},
+			&Inet{Valid: false},
+			&Inet{Valid: false},
+		}, Valid: true, Type: arrow.ListOf(types.ExtensionTypes.Inet)}},
 	}
 
 	for i, tt := range successfulTests {