fix race in test

disq · disq · commit 7326b3fa8655 · 2025-06-09T14:49:25.000+01:00
diff --git a/writers/streamingbatchwriter/streamingbatchwriter_test.go b/writers/streamingbatchwriter/streamingbatchwriter_test.go
@@ -79,9 +79,13 @@ func (c *testStreamingBatchClient) WriteTable(ctx context.Context, msgs <-chan *
 	key := ""
 	for m := range msgs {
 		key = c.handleTypeMessage(ctx, messageTypeInsert, m, key)
+
+		c.mutex.Lock()
 		c.writeCounter[key]++
+		currentCount := c.writeCounter[key]
+		c.mutex.Unlock()
 
-		if c.writeErr != nil && c.writeCounter[key] > c.writeErrAfter {
+		if c.writeErr != nil && currentCount > c.writeErrAfter {
 			return c.writeErr // leave msgs open
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -79,9 +79,13 @@ func (c testStreamingBatchClient) WriteTable(ctx context.Context, msgs <-chan `
`79`	`79`	`key := ""`
`80`	`80`	`for m := range msgs {`
`81`	`81`	`key = c.handleTypeMessage(ctx, messageTypeInsert, m, key)`
	`82`	`+`
	`83`	`+ c.mutex.Lock()`
`82`	`84`	`c.writeCounter[key]++`
	`85`	`+ currentCount := c.writeCounter[key]`
	`86`	`+ c.mutex.Unlock()`
`83`	`87`
`84`		`- if c.writeErr != nil && c.writeCounter[key] > c.writeErrAfter {`
	`88`	`+ if c.writeErr != nil && currentCount > c.writeErrAfter {`
`85`	`89`	`return c.writeErr // leave msgs open`
`86`	`90`	`}`
`87`	`91`	`}`