fix(testing): Fix bug in testing missed due to reference to resource being re-used in memdb (#567)

Author: hermanschaaf

plugins/destination/plugin_testing.go

@@ -77,15 +77,20 @@ func (s *PluginTestSuite) destinationPluginTestWriteOverwrite(ctx context.Contex
 
 	if diff := resources[1].Data.Diff(resourcesRead[1]); diff != "" {
 		return fmt.Errorf("expected second resource diff: %s", diff)
-		// return fmt.Errorf("expected second resource to be:\n%v\ngot:\n%v", resource.Data, resourcesRead[1])
 	}
 
 	secondSyncTime := syncTime.Add(time.Second).UTC()
-	_ = resources[0].Data[1].Set(secondSyncTime)
-	sortResources(table, resources)
+
+	// copy first resource but update the sync time
+	updatedResource := schema.DestinationResource{
+		TableName: table.Name,
+		Data:      make(schema.CQTypes, len(resources[0].Data)),
+	}
+	copy(updatedResource.Data, resources[0].Data)
+	_ = updatedResource.Data[1].Set(secondSyncTime)
 
 	// write second time
-	if err := p.writeOne(ctx, tables, sourceName, secondSyncTime, resources[0]); err != nil {
+	if err := p.writeOne(ctx, tables, sourceName, secondSyncTime, updatedResource); err != nil {
 		return fmt.Errorf("failed to write one second time: %w", err)
 	}
 
@@ -99,11 +104,11 @@ func (s *PluginTestSuite) destinationPluginTestWriteOverwrite(ctx context.Contex
 		return fmt.Errorf("after overwrite expected 2 resources, got %d", len(resourcesRead))
 	}
 
-	if diff := resources[0].Data.Diff(resourcesRead[0]); diff != "" {
+	if diff := resources[1].Data.Diff(resourcesRead[0]); diff != "" {
 		return fmt.Errorf("after overwrite expected first resource diff: %s", diff)
 	}
 
-	if diff := resources[1].Data.Diff(resourcesRead[1]); diff != "" {
+	if diff := updatedResource.Data.Diff(resourcesRead[1]); diff != "" {
 		return fmt.Errorf("after overwrite expected second resource diff: %s", diff)
 	}
 
@@ -123,8 +128,8 @@ func (s *PluginTestSuite) destinationPluginTestWriteOverwrite(ctx context.Contex
 		return fmt.Errorf("expected 1 resource after delete stale, got %d", len(resourcesRead))
 	}
 
-	// we expect the only resource returned to match the second resource we wrote
-	if diff := resources[1].Data.Diff(resourcesRead[0]); diff != "" {
+	// we expect the only resource returned to match the updated resource we wrote
+	if diff := updatedResource.Data.Diff(resourcesRead[0]); diff != "" {
 		return fmt.Errorf("after delete stale expected resource diff: %s", diff)
 	}
 
@@ -254,8 +259,8 @@ func sortResources(table *schema.Table, resources []schema.DestinationResource)
 	syncTimeIndex := table.Columns.Index(schema.CqSyncTimeColumn.Name)
 	sort.Slice(resources, func(i, j int) bool {
 		// sort by sync time, then UUID
-		if resources[i].Data[syncTimeIndex].String() != resources[j].Data[syncTimeIndex].String() {
-			return resources[i].Data[syncTimeIndex].String() < resources[j].Data[syncTimeIndex].String()
+		if !resources[i].Data[syncTimeIndex].Equal(resources[j].Data[syncTimeIndex]) {
+			return resources[i].Data[syncTimeIndex].Get().(time.Time).Before(resources[j].Data[syncTimeIndex].Get().(time.Time))
 		}
 		return resources[i].Data[cqIDIndex].String() < resources[j].Data[cqIDIndex].String()
 	})
@@ -266,8 +271,8 @@ func sortCQTypes(table *schema.Table, resources []schema.CQTypes) {
 	syncTimeIndex := table.Columns.Index(schema.CqSyncTimeColumn.Name)
 	sort.Slice(resources, func(i, j int) bool {
 		// sort by sync time, then UUID
-		if resources[i][syncTimeIndex].String() != resources[j][syncTimeIndex].String() {
-			return resources[i][syncTimeIndex].String() < resources[j][syncTimeIndex].String()
+		if !resources[i][syncTimeIndex].Equal(resources[j][syncTimeIndex]) {
+			return resources[i][syncTimeIndex].Get().(time.Time).Before(resources[j][syncTimeIndex].Get().(time.Time))
 		}
 		return resources[i][cqIDIndex].String() < resources[j][cqIDIndex].String()
 	})