fix(writers): Assert unimplemented interface at compile-time (#857)

Author: candiduslynx

plugins/destination/plugin.go

@@ -33,22 +33,26 @@ type ManagedWriter interface {
 
 type UnimplementedManagedWriter struct{}
 
+var _ ManagedWriter = UnimplementedManagedWriter{}
+
+func (UnimplementedManagedWriter) WriteTableBatch(context.Context, *schema.Table, []arrow.Record) error {
+	panic("WriteTableBatch not implemented")
+}
+
 type UnmanagedWriter interface {
 	Write(ctx context.Context, tables schema.Tables, res <-chan arrow.Record) error
 	Metrics() Metrics
 }
 
-type UnimplementedUnmanagedWriter struct{}
+var _ UnmanagedWriter = UnimplementedUnmanagedWriter{}
 
-func (*UnimplementedManagedWriter) WriteTableBatch(context.Context, *arrow.Schema, []arrow.Record) error {
-	panic("WriteTableBatch not implemented")
-}
+type UnimplementedUnmanagedWriter struct{}
 
-func (*UnimplementedUnmanagedWriter) Write(context.Context, schema.Schemas, <-chan arrow.Record) error {
+func (UnimplementedUnmanagedWriter) Write(context.Context, schema.Tables, <-chan arrow.Record) error {
 	panic("Write not implemented")
 }
 
-func (*UnimplementedUnmanagedWriter) Metrics() Metrics {
+func (UnimplementedUnmanagedWriter) Metrics() Metrics {
 	panic("Metrics not implemented")
 }