feat: Revert "feat(test): Test writing to a child table" (#880)

Reverts #878

As far as I can see there is no need for this because over the wire it
is always flattened anyway and in general I think we should move to
always flatten structure as it causes more harm then good.

Author: yevgenypats

internal/memdb/memdb.go

@@ -95,7 +95,7 @@ func (c *client) overwrite(table *schema.Table, data arrow.Record) {
 }
 
 func (c *client) Migrate(_ context.Context, tables schema.Tables) error {
-	for _, table := range tables.FlattenTables() {
+	for _, table := range tables {
 		tableName := table.Name
 		memTable := c.memoryDB[tableName]
 		if memTable == nil {

plugins/destination/plugin_testing_overwrite.go

@@ -20,10 +20,11 @@ func (*PluginTestSuite) destinationPluginTestWriteOverwrite(ctx context.Context,
 	}
 	tableName := fmt.Sprintf("cq_%s_%d", spec.Name, time.Now().Unix())
 	table := schema.TestTable(tableName, testSourceOptions...)
-	parent := schema.TestTable(tableName+"_parent", testSourceOptions...)
-	parent.Relations = schema.Tables{table}
 	syncTime := time.Now().UTC().Round(1 * time.Second)
-	if err := p.Migrate(ctx, schema.Tables{parent}); err != nil {
+	tables := schema.Tables{
+		table,
+	}
+	if err := p.Migrate(ctx, tables); err != nil {
 		return fmt.Errorf("failed to migrate tables: %w", err)
 	}
 

plugins/destination/plugin_testing_overwrite_delete_stale.go

@@ -22,10 +22,12 @@ func (*PluginTestSuite) destinationPluginTestWriteOverwriteDeleteStale(ctx conte
 	table := schema.TestTable(tableName, testSourceOptions...)
 	incTable := schema.TestTable(tableName+"_incremental", testSourceOptions...)
 	incTable.IsIncremental = true
-	parent := schema.TestTable(tableName+"_parent", testSourceOptions...)
-	parent.Relations = schema.Tables{table, incTable}
 	syncTime := time.Now().UTC().Round(1 * time.Second)
-	if err := p.Migrate(ctx, schema.Tables{parent}); err != nil {
+	tables := schema.Tables{
+		table,
+		incTable,
+	}
+	if err := p.Migrate(ctx, tables); err != nil {
 		return fmt.Errorf("failed to migrate tables: %w", err)
 	}
 
@@ -106,7 +108,7 @@ func (*PluginTestSuite) destinationPluginTestWriteOverwriteDeleteStale(ctx conte
 		return fmt.Errorf("after overwrite expected first resource to be different. diff: %s", diff)
 	}
 
-	resourcesRead, err = p.readAll(ctx, table, sourceName)
+	resourcesRead, err = p.readAll(ctx, tables[0], sourceName)
 	if err != nil {
 		return fmt.Errorf("failed to read all second time: %w", err)
 	}
@@ -122,7 +124,7 @@ func (*PluginTestSuite) destinationPluginTestWriteOverwriteDeleteStale(ctx conte
 
 	// we expect the incremental table to still have 2 resources, because delete-stale should
 	// not apply there
-	resourcesRead, err = p.readAll(ctx, incTable, sourceName)
+	resourcesRead, err = p.readAll(ctx, tables[1], sourceName)
 	if err != nil {
 		return fmt.Errorf("failed to read all from incremental table: %w", err)
 	}

plugins/destination/plugin_testing_write_append.go

@@ -19,10 +19,11 @@ func (s *PluginTestSuite) destinationPluginTestWriteAppend(ctx context.Context,
 	}
 	tableName := fmt.Sprintf("cq_%s_%d", spec.Name, time.Now().Unix())
 	table := schema.TestTable(tableName, testSourceOptions...)
-	parent := schema.TestTable(tableName+"_parent", testSourceOptions...)
-	parent.Relations = schema.Tables{table}
 	syncTime := time.Now().UTC().Round(1 * time.Second)
-	if err := p.Migrate(ctx, schema.Tables{parent}); err != nil {
+	tables := schema.Tables{
+		table,
+	}
+	if err := p.Migrate(ctx, tables); err != nil {
 		return fmt.Errorf("failed to migrate tables: %w", err)
 	}
 
@@ -52,7 +53,7 @@ func (s *PluginTestSuite) destinationPluginTestWriteAppend(ctx context.Context,
 		}
 	}
 
-	resourcesRead, err := p.readAll(ctx, table, sourceName)
+	resourcesRead, err := p.readAll(ctx, tables[0], sourceName)
 	if err != nil {
 		return fmt.Errorf("failed to read all second time: %w", err)
 	}