fix: Remove invocationID from metrics constructor calls

Author: murarustefaan

scheduler/metrics/metrics.go

@@ -29,7 +29,7 @@ var (
 	once      sync.Once
 )
 
-func NewMetrics(invocationID string) *Metrics {
+func NewMetrics() *Metrics {
 	once.Do(func() {
 		resources, _ = otel.Meter(ResourceName).Int64Counter(resourcesMetricName,
 			metric.WithDescription("Number of resources synced for a table"),
@@ -83,7 +83,7 @@ type measurement struct {
 	duration  *durationMeasurement
 }
 
-func (m *Metrics) NewSelector(clientID, tableName string) Selector {
+func (*Metrics) NewSelector(clientID, tableName string) Selector {
 	return Selector{
 		Set: attribute.NewSet(
 			attribute.Key("sync.table.name").String(tableName),

scheduler/metrics/metrics_test.go

@@ -8,7 +8,7 @@ import (
 )
 
 func TestMetrics(t *testing.T) {
-	m := NewMetrics("test_invocation_id")
+	m := NewMetrics()
 
 	m.measurements["test_table_1"] = tableMeasurements{
 		clients: map[string]*measurement{

scheduler/queue/scheduler_test.go

@@ -45,9 +45,8 @@ func testResolver(_ context.Context, _ schema.ClientMeta, parent *schema.Resourc
 
 func TestScheduler(t *testing.T) {
 	nopLogger := zerolog.Nop()
-	invocationID := uuid.New().String()
-	m := metrics.NewMetrics(invocationID)
-	scheduler := NewShuffleQueueScheduler(nopLogger, m, int64(0), WithWorkerCount(1000), WithInvocationID(invocationID))
+	m := metrics.NewMetrics()
+	scheduler := NewShuffleQueueScheduler(nopLogger, m, int64(0), WithWorkerCount(1000), WithInvocationID(uuid.New().String()))
 	tableClients := []WorkUnit{
 		{
 			Table: &schema.Table{

scheduler/scheduler.go

@@ -208,7 +208,7 @@ func (s *Scheduler) Sync(ctx context.Context, client schema.ClientMeta, tables s
 	}
 
 	syncClient := &syncClient{
-		metrics:      metrics.NewMetrics(s.invocationID),
+		metrics:      metrics.NewMetrics(),
 		tables:       tables,
 		client:       client,
 		scheduler:    s,