feat: Add Name() to source and destination clients (#29)

* feat: add Name() to source and destination clients

* Add separate name and version grpc calls

Author: hermanschaaf

clients/destination.go

@@ -14,7 +14,7 @@ import (
 
 type DestinationClient struct {
 	pbClient pb.DestinationClient
-	// this can be used if we have a plugin which is compiled in so we dont need to do any grpc requests
+	// this can be used if we have a plugin which is compiled in, so we don't need to do any grpc requests
 	localClient plugins.DestinationPlugin
 }
 
@@ -30,6 +30,28 @@ func NewLocalDestinationClient(p plugins.DestinationPlugin) *DestinationClient {
 	}
 }
 
+func (c *DestinationClient) Name(ctx context.Context) (string, error) {
+	if c.localClient != nil {
+		return c.localClient.Name(), nil
+	}
+	res, err := c.pbClient.GetName(ctx, &pb.GetName_Request{})
+	if err != nil {
+		return "", fmt.Errorf("failed to get name: %w", err)
+	}
+	return res.Name, nil
+}
+
+func (c *DestinationClient) Version(ctx context.Context) (string, error) {
+	if c.localClient != nil {
+		return c.localClient.Version(), nil
+	}
+	res, err := c.pbClient.GetVersion(ctx, &pb.GetVersion_Request{})
+	if err != nil {
+		return "", fmt.Errorf("failed to get version: %w", err)
+	}
+	return res.Version, nil
+}
+
 func (c *DestinationClient) GetExampleConfig(ctx context.Context) (string, error) {
 	if c.localClient != nil {
 		return c.localClient.ExampleConfig(), nil

clients/source.go

@@ -28,16 +28,20 @@ func NewSourceClient(cc grpc.ClientConnInterface) *SourceClient {
 	}
 }
 
-func (c *SourceClient) GetTables(ctx context.Context) ([]*schema.Table, error) {
-	res, err := c.pbClient.GetTables(ctx, &pb.GetTables_Request{})
+func (c *SourceClient) Name(ctx context.Context) (string, error) {
+	res, err := c.pbClient.GetName(ctx, &pb.GetName_Request{})
 	if err != nil {
-		return nil, err
+		return "", fmt.Errorf("failed to get name: %w", err)
 	}
-	var tables []*schema.Table
-	if err := json.Unmarshal(res.Tables, &tables); err != nil {
-		return nil, err
+	return res.Name, nil
+}
+
+func (c *SourceClient) Version(ctx context.Context) (string, error) {
+	res, err := c.pbClient.GetVersion(ctx, &pb.GetVersion_Request{})
+	if err != nil {
+		return "", fmt.Errorf("failed to get version: %w", err)
 	}
-	return tables, nil
+	return res.Version, nil
 }
 
 func (c *SourceClient) ExampleConfig(ctx context.Context) (string, error) {
@@ -48,6 +52,18 @@ func (c *SourceClient) ExampleConfig(ctx context.Context) (string, error) {
 	return res.Config, nil
 }
 
+func (c *SourceClient) GetTables(ctx context.Context) ([]*schema.Table, error) {
+	res, err := c.pbClient.GetTables(ctx, &pb.GetTables_Request{})
+	if err != nil {
+		return nil, err
+	}
+	var tables []*schema.Table
+	if err := json.Unmarshal(res.Tables, &tables); err != nil {
+		return nil, err
+	}
+	return tables, nil
+}
+
 func (c *SourceClient) Sync(ctx context.Context, spec specs.Source, res chan<- *schema.Resource) error {
 	b, err := json.Marshal(spec)
 	if err != nil {