fix!: Logger wasnt passed to source plugin resulting no errors (#49)

Author: yevgenypats

plugins/source.go

@@ -12,7 +12,7 @@ import (
 	"github.com/thoas/go-funk"
 )
 
-type SourceNewExecutionClientFunc func(context.Context, *SourcePlugin, specs.Source) (schema.ClientMeta, error)
+type SourceNewExecutionClientFunc func(context.Context, zerolog.Logger, specs.Source) (schema.ClientMeta, error)
 
 // SourcePlugin is the base structure required to pass to sdk.serve
 // We take a similar/declerative approach to API here similar to Cobra
@@ -121,7 +121,7 @@ func (p *SourcePlugin) SetLogger(log zerolog.Logger) {
 
 // Sync data from source to the given channel
 func (p *SourcePlugin) Sync(ctx context.Context, spec specs.Source, res chan<- *schema.Resource) error {
-	c, err := p.newExecutionClient(ctx, p, spec)
+	c, err := p.newExecutionClient(ctx, p.logger, spec)
 	if err != nil {
 		return fmt.Errorf("failed to create execution client for source plugin %s: %w", p.name, err)
 	}
@@ -138,7 +138,7 @@ func (p *SourcePlugin) Sync(ctx context.Context, spec specs.Source, res chan<- *
 	w := sync.WaitGroup{}
 	totalResources := 0
 	startTime := time.Now()
-	tableNames, err := p.interpolateAllResources(p.tables.TableNames())
+	tableNames, err := p.interpolateAllResources(spec.Tables)
 	if err != nil {
 		return err
 	}

plugins/source_test.go

@@ -53,7 +53,7 @@ func (c *testExecutionClient) Logger() *zerolog.Logger {
 	return &c.logger
 }
 
-func newTestExecutionClient(context.Context, *SourcePlugin, specs.Source) (schema.ClientMeta, error) {
+func newTestExecutionClient(context.Context, zerolog.Logger, specs.Source) (schema.ClientMeta, error) {
 	return &testExecutionClient{}, nil
 }
 

schema/table.go

@@ -154,10 +154,6 @@ func (t Table) ColumnIndex(name string) int {
 	return -1
 }
 
-// func (tco TableCreationOptions) signature() string {
-// 	return strings.Join(tco.PrimaryKeys, ";")
-// }
-
 func (t Table) TableNames() []string {
 	ret := []string{t.Name}
 	for _, rel := range t.Relations {
@@ -172,9 +168,9 @@ func (t Table) Resolve(ctx context.Context, meta ClientMeta, syncTime time.Time,
 	startTime := time.Now()
 	go func() {
 		defer func() {
-			if r := recover(); r != nil {
+			if err := recover(); err != nil {
 				stack := string(debug.Stack())
-				meta.Logger().Error().Str("table_name", t.Name).TimeDiff("duration", time.Now(), startTime).Str("stack", stack).Msg("table resolver finished with panic")
+				meta.Logger().Error().Interface("error", err).Str("table_name", t.Name).TimeDiff("duration", time.Now(), startTime).Str("stack", stack).Msg("table resolver finished with panic")
 			}
 			close(res)
 		}()

serve/serve_test.go

@@ -60,7 +60,7 @@ func (c *testExecutionClient) Logger() *zerolog.Logger {
 	return &c.logger
 }
 
-func newTestExecutionClient(context.Context, *plugins.SourcePlugin, specs.Source) (schema.ClientMeta, error) {
+func newTestExecutionClient(context.Context, zerolog.Logger, specs.Source) (schema.ClientMeta, error) {
 	return &testExecutionClient{}, nil
 }