feat(writers): More unimplemented writer helpers (#1038)

Just to get the other two in parity with streamingbatchwriter helpers, plus tests to make sure the interfaces are satisfied.

Author: disq

writers/batchwriter/unimplemented.go

@@ -0,0 +1,21 @@
+package batchwriter
+
+import (
+	"context"
+	"fmt"
+
+	"github.com/cloudquery/plugin-sdk/v4/message"
+	"github.com/cloudquery/plugin-sdk/v4/plugin"
+)
+
+type IgnoreMigrateTables struct{}
+
+func (IgnoreMigrateTables) MigrateTables(context.Context, message.WriteMigrateTables) error {
+	return nil
+}
+
+type UnimplementedDeleteStale struct{}
+
+func (UnimplementedDeleteStale) DeleteStale(context.Context, message.WriteDeleteStales) error {
+	return fmt.Errorf("DeleteStale: %w", plugin.ErrNotImplemented)
+}

writers/batchwriter/unimplemented_test.go

@@ -0,0 +1,19 @@
+package batchwriter_test
+
+import (
+	"context"
+
+	"github.com/cloudquery/plugin-sdk/v4/message"
+	"github.com/cloudquery/plugin-sdk/v4/writers/batchwriter"
+)
+
+type testDummyClient struct {
+	batchwriter.IgnoreMigrateTables
+	batchwriter.UnimplementedDeleteStale
+}
+
+func (testDummyClient) WriteTableBatch(context.Context, string, message.WriteInserts) error {
+	return nil
+}
+
+var _ batchwriter.Client = (*testDummyClient)(nil)

writers/mixedbatchwriter/unimplemented.go

@@ -0,0 +1,21 @@
+package mixedbatchwriter
+
+import (
+	"context"
+	"fmt"
+
+	"github.com/cloudquery/plugin-sdk/v4/message"
+	"github.com/cloudquery/plugin-sdk/v4/plugin"
+)
+
+type IgnoreMigrateTableBatch struct{}
+
+func (IgnoreMigrateTableBatch) MigrateTableBatch(context.Context, message.WriteMigrateTables) error {
+	return nil
+}
+
+type UnimplementedDeleteStaleBatch struct{}
+
+func (UnimplementedDeleteStaleBatch) DeleteStaleBatch(context.Context, message.WriteDeleteStales) error {
+	return fmt.Errorf("DeleteStaleBatch: %w", plugin.ErrNotImplemented)
+}

writers/mixedbatchwriter/unimplemented_test.go

@@ -0,0 +1,19 @@
+package mixedbatchwriter_test
+
+import (
+	"context"
+
+	"github.com/cloudquery/plugin-sdk/v4/message"
+	"github.com/cloudquery/plugin-sdk/v4/writers/mixedbatchwriter"
+)
+
+type testDummyClient struct {
+	mixedbatchwriter.IgnoreMigrateTableBatch
+	mixedbatchwriter.UnimplementedDeleteStaleBatch
+}
+
+func (testDummyClient) InsertBatch(context.Context, message.WriteInserts) error {
+	return nil
+}
+
+var _ mixedbatchwriter.Client = (*testDummyClient)(nil)

writers/streamingbatchwriter/unimplemented.go

@@ -2,26 +2,25 @@ package streamingbatchwriter
 
 import (
 	"context"
+	"fmt"
 
 	"github.com/cloudquery/plugin-sdk/v4/message"
+	"github.com/cloudquery/plugin-sdk/v4/plugin"
 )
 
-// UnimplementedMigrateTable is a dummy handler to consume WriteMigrateTable messages
-type UnimplementedMigrateTable struct{}
+// IgnoreMigrateTable is a dummy handler to consume WriteMigrateTable messages
+type IgnoreMigrateTable struct{}
 
-func (UnimplementedMigrateTable) MigrateTable(_ context.Context, ch <-chan *message.WriteMigrateTable) error {
+func (IgnoreMigrateTable) MigrateTable(_ context.Context, ch <-chan *message.WriteMigrateTable) error {
 	// nolint:revive
 	for range ch {
 	}
 	return nil
 }
 
-// UnimplementedDeleteStale is a dummy handler to consume DeleteStale messages
+// UnimplementedDeleteStale is a dummy handler to error on DeleteStale messages
 type UnimplementedDeleteStale struct{}
 
-func (UnimplementedDeleteStale) DeleteStale(_ context.Context, ch <-chan *message.WriteDeleteStale) error {
-	// nolint:revive
-	for range ch {
-	}
-	return nil
+func (UnimplementedDeleteStale) DeleteStale(_ context.Context, _ <-chan *message.WriteDeleteStale) error {
+	return fmt.Errorf("DeleteStale: %w", plugin.ErrNotImplemented)
 }

writers/streamingbatchwriter/unimplemented_test.go

@@ -0,0 +1,19 @@
+package streamingbatchwriter_test
+
+import (
+	"context"
+
+	"github.com/cloudquery/plugin-sdk/v4/message"
+	"github.com/cloudquery/plugin-sdk/v4/writers/streamingbatchwriter"
+)
+
+type testDummyClient struct {
+	streamingbatchwriter.IgnoreMigrateTable
+	streamingbatchwriter.UnimplementedDeleteStale
+}
+
+func (testDummyClient) WriteTable(context.Context, <-chan *message.WriteInsert) error {
+	return nil
+}
+
+var _ streamingbatchwriter.Client = (*testDummyClient)(nil)